Solr
  1. Solr
  2. SOLR-6604

distributed expand=true&fl=key NPE fix, expand=true&distrib.singlePass=true consideration

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.0, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      select?expand=true&fl=key hits NPE in ExpandComponent.handleResponse when the responses of the EXECUTE_QUERY contain no expanded element despite the requests' purpose including PURPOSE_GET_FIELDS

      select?expand=true&distrib.singlePass=true works but relies on other preceding components triggering a GET_FIELDS stage

      1. SOLR-6604.patch
        18 kB
        Shalin Shekhar Mangar

        Issue Links

          Activity

          Hide
          ASF GitHub Bot added a comment -

          GitHub user cpoerschke opened a pull request:

          https://github.com/apache/lucene-solr/pull/98

          distributed expand=true&fl=key NPE fix, expand=true&distrib.singlePass=true consideration

          https://issues.apache.org/jira/i#browse/SOLR-6604

          scenario:

          • select?expand=true&fl=key hit NPE in ExpandComponent.handleResponse when the responses of the EXECUTE_QUERY contained no expanded element despite the requests' purpose including PURPOSE_GET_FIELDS
          • select?expand=true&distrib.singlePass=true worked but relied on other preceding components triggering a GET_FIELDS stage

          changes:

          • add TestExpandComponent and DistributedExpandComponentTest test cases
          • change code to fix NPE
          • change code to avoid distrib.singlePass reliance on other components
          • tweak test cases to randomly alternate between docValues=false and docValues=true collapse fields

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/bloomberg/lucene-solr trunk-collapse-expand

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/lucene-solr/pull/98.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #98


          commit c7c79f24230e3f6470e3ee58c9e58346dc1b043b
          Author: Christine Poerschke <cpoerschke@bloomberg.net>
          Date: 2014-09-08T10:06:41Z

          solr: distributed select?expand=true&fl=key NPE fix, select?expand=true&distrib.singlePass=true consideration

          scenario:

          • select?expand=true&fl=key hit NPE in ExpandComponent.handleResponse when the responses of the EXECUTE_QUERY contained no expanded element despite the requests' purpose including PURPOSE_GET_FIELDS
          • select?expand=true&distrib.singlePass=true worked but relied on other preceding components triggering a GET_FIELDS stage

          changes:

          • add TestExpandComponent and DistributedExpandComponentTest test cases
          • change code to fix NPE
          • change code to avoid distrib.singlePass reliance on other components
          • tweak test cases to randomly alternate between docValues=false and docValues=true collapse fields

          Show
          ASF GitHub Bot added a comment - GitHub user cpoerschke opened a pull request: https://github.com/apache/lucene-solr/pull/98 distributed expand=true&fl=key NPE fix, expand=true&distrib.singlePass=true consideration https://issues.apache.org/jira/i#browse/SOLR-6604 scenario: select?expand=true&fl=key hit NPE in ExpandComponent.handleResponse when the responses of the EXECUTE_QUERY contained no expanded element despite the requests' purpose including PURPOSE_GET_FIELDS select?expand=true&distrib.singlePass=true worked but relied on other preceding components triggering a GET_FIELDS stage changes: add TestExpandComponent and DistributedExpandComponentTest test cases change code to fix NPE change code to avoid distrib.singlePass reliance on other components tweak test cases to randomly alternate between docValues=false and docValues=true collapse fields You can merge this pull request into a Git repository by running: $ git pull https://github.com/bloomberg/lucene-solr trunk-collapse-expand Alternatively you can review and apply these changes as the patch at: https://github.com/apache/lucene-solr/pull/98.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #98 commit c7c79f24230e3f6470e3ee58c9e58346dc1b043b Author: Christine Poerschke <cpoerschke@bloomberg.net> Date: 2014-09-08T10:06:41Z solr: distributed select?expand=true&fl=key NPE fix, select?expand=true&distrib.singlePass=true consideration scenario: select?expand=true&fl=key hit NPE in ExpandComponent.handleResponse when the responses of the EXECUTE_QUERY contained no expanded element despite the requests' purpose including PURPOSE_GET_FIELDS select?expand=true&distrib.singlePass=true worked but relied on other preceding components triggering a GET_FIELDS stage changes: add TestExpandComponent and DistributedExpandComponentTest test cases change code to fix NPE change code to avoid distrib.singlePass reliance on other components tweak test cases to randomly alternate between docValues=false and docValues=true collapse fields
          Hide
          Christine Poerschke added a comment -

          SOLR-6604 and SOLR-6510 proposed patches share the same one-line solr/core/src/test-files/solr/collection1/conf/schema11.xml change (but the github pull requests are independent of each other).

          Show
          Christine Poerschke added a comment - SOLR-6604 and SOLR-6510 proposed patches share the same one-line solr/core/src/test-files/solr/collection1/conf/schema11.xml change (but the github pull requests are independent of each other).
          Hide
          Christine Poerschke added a comment -

          Linking SOLR-6604 and SOLR-6812 which both concern distrib.singlePass and expand.

          Show
          Christine Poerschke added a comment - Linking SOLR-6604 and SOLR-6812 which both concern distrib.singlePass and expand.
          Hide
          Shalin Shekhar Mangar added a comment -

          Hi Christine Poerschke, I combined my patch on SOLR-6812 and your patch which is attached here. I used the modifyRequest method to enable expansion selectively on the shard requests. The rest of the patch is the same as yours.

          Show
          Shalin Shekhar Mangar added a comment - Hi Christine Poerschke , I combined my patch on SOLR-6812 and your patch which is attached here. I used the modifyRequest method to enable expansion selectively on the shard requests. The rest of the patch is the same as yours.
          Hide
          ASF subversion and git services added a comment -

          Commit 1645098 from shalin@apache.org in branch 'dev/trunk'
          [ https://svn.apache.org/r1645098 ]

          SOLR-6604: SOLR-6812: Fix NPE with distrib.singlePass=true and expand component. Increased test coverage of expand component with docValues.

          This closes #98.

          Show
          ASF subversion and git services added a comment - Commit 1645098 from shalin@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1645098 ] SOLR-6604 : SOLR-6812 : Fix NPE with distrib.singlePass=true and expand component. Increased test coverage of expand component with docValues. This closes #98.
          Hide
          ASF subversion and git services added a comment -

          Commit 1645099 from shalin@apache.org in branch 'dev/branches/branch_5x'
          [ https://svn.apache.org/r1645099 ]

          SOLR-6604: SOLR-6812: Fix NPE with distrib.singlePass=true and expand component. Increased test coverage of expand component with docValues.

          This closes #98.

          Show
          ASF subversion and git services added a comment - Commit 1645099 from shalin@apache.org in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1645099 ] SOLR-6604 : SOLR-6812 : Fix NPE with distrib.singlePass=true and expand component. Increased test coverage of expand component with docValues. This closes #98.
          Hide
          Shalin Shekhar Mangar added a comment -

          Thanks Christine!

          Show
          Shalin Shekhar Mangar added a comment - Thanks Christine!
          Hide
          ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/lucene-solr/pull/98

          Show
          ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/lucene-solr/pull/98
          Hide
          Anshum Gupta added a comment -

          Bulk close after 5.0 release.

          Show
          Anshum Gupta added a comment - Bulk close after 5.0 release.

            People

            • Assignee:
              Shalin Shekhar Mangar
              Reporter:
              Christine Poerschke
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development