Solr
  1. Solr
  2. SOLR-6603

LBHttpSolrServer - lazily allocate skipped-zombie-servers list

    Details

    • Type: Wish Wish
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.0, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      On the assumption that for most requests the list would actually remain empty lazy allocation would save a small amount of allocation/subsequent garbage collection for most requests.

        Activity

        Hide
        ASF GitHub Bot added a comment -

        GitHub user cpoerschke opened a pull request:

        https://github.com/apache/lucene-solr/pull/97

        LBHttpSolrServer - lazily allocate skipped-zombie-servers list

        https://issues.apache.org/jira/i#browse/SOLR-6603

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/bloomberg/lucene-solr trunk-LBHttpSolrServer-lazy-zombies-skipped

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/lucene-solr/pull/97.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #97


        commit bd9ee28d1b6cf26f55689bf5079b4fca1caa317b
        Author: Christine Poerschke <cpoerschke@bloomberg.net>
        Date: 2014-09-19T11:16:26Z

        solr: LBHttpSolrServer - lazily allocate skipped-zombie-servers list


        Show
        ASF GitHub Bot added a comment - GitHub user cpoerschke opened a pull request: https://github.com/apache/lucene-solr/pull/97 LBHttpSolrServer - lazily allocate skipped-zombie-servers list https://issues.apache.org/jira/i#browse/SOLR-6603 You can merge this pull request into a Git repository by running: $ git pull https://github.com/bloomberg/lucene-solr trunk-LBHttpSolrServer-lazy-zombies-skipped Alternatively you can review and apply these changes as the patch at: https://github.com/apache/lucene-solr/pull/97.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #97 commit bd9ee28d1b6cf26f55689bf5079b4fca1caa317b Author: Christine Poerschke <cpoerschke@bloomberg.net> Date: 2014-09-19T11:16:26Z solr: LBHttpSolrServer - lazily allocate skipped-zombie-servers list
        Hide
        ASF subversion and git services added a comment -

        Commit 1630285 from shalin@apache.org in branch 'dev/trunk'
        [ https://svn.apache.org/r1630285 ]

        SOLR-6603: LBHttpSolrServer - lazily allocate skipped-zombie-servers list. (This closes #97)

        Show
        ASF subversion and git services added a comment - Commit 1630285 from shalin@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1630285 ] SOLR-6603 : LBHttpSolrServer - lazily allocate skipped-zombie-servers list. (This closes #97)
        Hide
        ASF subversion and git services added a comment -

        Commit 1630286 from shalin@apache.org in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1630286 ]

        SOLR-6603: LBHttpSolrServer - lazily allocate skipped-zombie-servers list. (This closes #97)

        Show
        ASF subversion and git services added a comment - Commit 1630286 from shalin@apache.org in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1630286 ] SOLR-6603 : LBHttpSolrServer - lazily allocate skipped-zombie-servers list. (This closes #97)
        Hide
        Shalin Shekhar Mangar added a comment -

        Thanks Christine!

        Show
        Shalin Shekhar Mangar added a comment - Thanks Christine!
        Hide
        ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/lucene-solr/pull/97

        Show
        ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/lucene-solr/pull/97
        Hide
        Anshum Gupta added a comment -

        Bulk close after 5.0 release.

        Show
        Anshum Gupta added a comment - Bulk close after 5.0 release.

          People

          • Assignee:
            Shalin Shekhar Mangar
            Reporter:
            Christine Poerschke
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development