Solr
  1. Solr
  2. SOLR-6597

SolrIndexConfig parameter in SolrIndexSearcher constructor is not used

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.10
    • Fix Version/s: 5.0
    • Component/s: None
    • Labels:
      None

      Description

      The following constructor of SolrIndexSearcher doesn't use 'config'.

      SolrIndexSearcher
      public SolrIndexSearcher(SolrCore core, String path, IndexSchema schema, SolrIndexConfig config, String name, DirectoryReader r, boolean closeReader, boolean enableCache, boolean reserveDirectory, DirectoryFactory directoryFactory)
      

      It doesn't make sense to pass in the SolrIndexConfig when we're passing in the DirectoryReader (and asserting that it's never null). Prior to LUCENE-5666, when 'r' was null, the config was used to get a reader but not any more.

      I'll just remove the param from the constructor and remove it from all places that calls this version of the constructor.

      1. SOLR-6597.patch
        4 kB
        Anshum Gupta

        Activity

        Hide
        ASF subversion and git services added a comment -

        Commit 1629772 from Anshum Gupta in branch 'dev/trunk'
        [ https://svn.apache.org/r1629772 ]

        SOLR-6597: Removed SolrIndexConfig parameter from one of the SolrIndexSearcher constructor, where it was never really used

        Show
        ASF subversion and git services added a comment - Commit 1629772 from Anshum Gupta in branch 'dev/trunk' [ https://svn.apache.org/r1629772 ] SOLR-6597 : Removed SolrIndexConfig parameter from one of the SolrIndexSearcher constructor, where it was never really used
        Hide
        ASF subversion and git services added a comment -

        Commit 1629784 from Anshum Gupta in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1629784 ]

        SOLR-6597: Removed SolrIndexConfig parameter from one of the SolrIndexSearcher constructor, where it was never really used (merge from trunk r1629772)

        Show
        ASF subversion and git services added a comment - Commit 1629784 from Anshum Gupta in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1629784 ] SOLR-6597 : Removed SolrIndexConfig parameter from one of the SolrIndexSearcher constructor, where it was never really used (merge from trunk r1629772)
        Hide
        Anshum Gupta added a comment -

        Bulk close after 5.0 release.

        Show
        Anshum Gupta added a comment - Bulk close after 5.0 release.

          People

          • Assignee:
            Anshum Gupta
            Reporter:
            Anshum Gupta
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development