Solr
  1. Solr
  2. SOLR-6578

Update commons-io dependency to the latest 2.4 version

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.0, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      Latest commons-io version is 2.4, but Solr 4.10 still uses 2.3. It is also required by the Couchbase plugin for Solr (SOLR-6266) that Solr uses commons-io-2.4.

      1. SOLR-6578.patch
        1 kB
        Shawn Heisey

        Issue Links

          Activity

          Hide
          Shawn Heisey added a comment -

          I've tried to update this in branch_5x, but there seem to be tons of tests failing. I haven't yet been able to determine if they are failing because of the ivy dependency change or because of the other large-scale changes made to pull applicable trunk changes into 5x. Later I'll be able to try it on the 4_10 branch, but I think all my time for working on this tonight has evaporated.

          Show
          Shawn Heisey added a comment - I've tried to update this in branch_5x, but there seem to be tons of tests failing. I haven't yet been able to determine if they are failing because of the ivy dependency change or because of the other large-scale changes made to pull applicable trunk changes into 5x. Later I'll be able to try it on the 4_10 branch, but I think all my time for working on this tonight has evaporated.
          Hide
          Shawn Heisey added a comment -

          Patch for branch_5x updating commons-io to 2.4.

          Show
          Shawn Heisey added a comment - Patch for branch_5x updating commons-io to 2.4.
          Hide
          Steve Rowe added a comment -

          +1 to commit.

          All Solr tests passed for me on trunk with the patch.

          According to the commons-io 2.4 release notes:

          Compatibility with 2.3:
          Binary compatible: Yes.
          Source compatible: Yes.
          Semantic compatible: Yes.

          Show
          Steve Rowe added a comment - +1 to commit. All Solr tests passed for me on trunk with the patch. According to the commons-io 2.4 release notes : Compatibility with 2.3: Binary compatible: Yes. Source compatible: Yes. Semantic compatible: Yes.
          Hide
          ASF subversion and git services added a comment -

          Commit 1633718 from Use account "steve_rowe" instead in branch 'dev/trunk'
          [ https://svn.apache.org/r1633718 ]

          SOLR-6578: Update commons-io dependency to the latest 2.4 version

          Show
          ASF subversion and git services added a comment - Commit 1633718 from Use account "steve_rowe" instead in branch 'dev/trunk' [ https://svn.apache.org/r1633718 ] SOLR-6578 : Update commons-io dependency to the latest 2.4 version
          Hide
          ASF subversion and git services added a comment -

          Commit 1633719 from Use account "steve_rowe" instead in branch 'dev/branches/branch_5x'
          [ https://svn.apache.org/r1633719 ]

          SOLR-6578: Update commons-io dependency to the latest 2.4 version (merged trunk r1633718)

          Show
          ASF subversion and git services added a comment - Commit 1633719 from Use account "steve_rowe" instead in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1633719 ] SOLR-6578 : Update commons-io dependency to the latest 2.4 version (merged trunk r1633718)
          Hide
          ASF subversion and git services added a comment -

          Commit 1633721 from Use account "steve_rowe" instead in branch 'dev/trunk'
          [ https://svn.apache.org/r1633721 ]

          SOLR-6578: added CHANGES.txt entry

          Show
          ASF subversion and git services added a comment - Commit 1633721 from Use account "steve_rowe" instead in branch 'dev/trunk' [ https://svn.apache.org/r1633721 ] SOLR-6578 : added CHANGES.txt entry
          Hide
          ASF subversion and git services added a comment -

          Commit 1633722 from Use account "steve_rowe" instead in branch 'dev/branches/branch_5x'
          [ https://svn.apache.org/r1633722 ]

          SOLR-6578: added CHANGES.txt entry (merged trunk r1633721)

          Show
          ASF subversion and git services added a comment - Commit 1633722 from Use account "steve_rowe" instead in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1633722 ] SOLR-6578 : added CHANGES.txt entry (merged trunk r1633721)
          Hide
          Steve Rowe added a comment -

          Committed to trunk and branch_5x.

          Show
          Steve Rowe added a comment - Committed to trunk and branch_5x.
          Hide
          Anshum Gupta added a comment -

          Bulk close after 5.0 release.

          Show
          Anshum Gupta added a comment - Bulk close after 5.0 release.
          Hide
          Mikhail Khludnev added a comment -

          Steve Rowe, what about bumping commons-io to next 2.5? I described a reason at SOLR-797

          Show
          Mikhail Khludnev added a comment - Steve Rowe , what about bumping commons-io to next 2.5? I described a reason at SOLR-797
          Hide
          Steve Rowe added a comment -

          Mikhail Khludnev: +1 - from the 2.5 release notes http://commons.apache.org/proper/commons-io/upgradeto2_5.html:

           Compatibility with 2.3:
                              Binary compatible: Yes.
                              Source compatible: Yes.
                              Semantic compatible: Yes.
          
          Show
          Steve Rowe added a comment - Mikhail Khludnev : +1 - from the 2.5 release notes http://commons.apache.org/proper/commons-io/upgradeto2_5.html : Compatibility with 2.3: Binary compatible: Yes. Source compatible: Yes. Semantic compatible: Yes.

            People

            • Assignee:
              Steve Rowe
              Reporter:
              Karol Abramczyk
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development