[SOLR-6541] Enhancement for SOLR-6452 StatsComponent "missing" stat won't work with docValues=true and indexed=false

• Type: Improvement
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 4.10, 6.0
• Fix Version/s: 5.0, 6.0
• Assignee: Unassigned
• Reporter: Vitaliy Zhovtyuk
• Created: 19/Sep/14 07:59
• Updated: 09/May/16 18:43

Description

This issue is refactoring of solution provided in SOLR-6452 StatsComponent "missing" stat won't work with docValues=true and indexed=false.
I think the following points need to be addressed:
1. Accumulate methods should not return stats specific numbers (it is generic). Attached solution with container class. Also made them private scoped.
Returning just missing fields from accumulate methods does not allow you to extend it with additional counts field, therefore i propose to leave void.
2. Reduced visibility of fields in FieldFacetStats.
3. Methods FieldFacetStats#accumulateMissing and FieldFacetStats#accumulateTermNum does not throw any IO exception
4. We don't need intermediate maps to accumulate missing counts. Method org.apache.solr.handler.component.FieldFacetStats#facetMissingNum
can be changed to work directly on StatsValues structure and removed org.apache.solr.handler.component.FieldFacetStats#accumulateMissing.
We don't need to have it in 2 phases.

Issue Links

• relates to: SOLR-6452 StatsComponent "missing" stat won't work with docValues=true and indexed=false