[SOLR-6518] CachingDirectoryFactory subclasses must init directory with NoLockFactory, because the real lock factory gets set later via injectLockFactory

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 6.0
• Fix Version/s: 6.0
• Assignee: Uwe Schindler
• Reporter: Uwe Schindler
• Created: 15/Sep/14 00:45
• Updated: 09/May/16 18:53
• Resolved: 15/Sep/14 00:50

Description

The whole setup should really be changed in Solr trunk, especially as we want to make the lockfactory non-mutable (set via directory ctor).

As workaround to prevent SimpleFSLockFactory from creating the lock directory initially, we should pass NoLockFactory in the create method. This is possible because injectLockFactory will set the "configured one" afterwards.

This change is needed in trunk, because the LockFactory creates the directory in its ctor, which leads to problems with NIO2.

In addition, the SlrCore.newSolrDataDir does not cleanup and close the directory correctly if an error occurs.

Issue Links

• is superceded by: SOLR-6519 In trunk change Solr's DirectoryFactory.create method to take LockFactory