[SOLR-6511] Fencepost error in LeaderInitiatedRecoveryThread

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 4.10.2, 5.0
• Assignee: Timothy Potter
• Reporter: Alan Woodward
• Created: 12/Sep/14 21:16
• Updated: 29/Oct/14 17:38
• Resolved: 13/Oct/14 20:36

Description

At line 106:

    while (continueTrying && ++tries < maxTries) {

should be

    while (continueTrying && ++tries <= maxTries) {

This is only a problem when called from DistributedUpdateProcessor, as it can have maxTries set to 1, which means the loop is never actually run.