Solr
  1. Solr
  2. SOLR-6483

Refactor some methods in MiniSolrCloudCluster tests

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 5.0, 6.0
    • Fix Version/s: 5.0, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      Looking at whether we can provide some ease-of-use methods in MiniSolrCloudCluster

      1. SOLR-6483.patch
        13 kB
        Erick Erickson
      2. SOLR-6483.patch
        13 kB
        Steve Davids

        Activity

        Hide
        Steve Davids added a comment -

        Initial patch which has allowed additional convenience methods in the MiniSolrCloudCluster including:

        1. Upload a config directory to ZooKeeper
        2. Create a collection
          • Added ability to provide collection properties
        3. Use a pre-configured CloudSolrServer instance

        The TestMiniSolrCloudCluster has been refactored to use these new methods.

        A few additional changes that should still be done:

        1. Provide waitForRecoveriesToFinish convenience method in MiniSolrCloudCluster
          • The code in the test is almost a direct copy/past from AbstractDistribZkTestBase.waitForRecoveriesToFinish, it would be nice to refactor this code into a common class (as this is not trivial code to maintain).
        2. All system properties were dropped except for solr.solrxml.location & zkHost because those are necessary for Jetty to know where to pick up it's configuration on initial startup. It would be nice to see if there is an alternate way of getting that information to Jetty without setting the system property.
        Show
        Steve Davids added a comment - Initial patch which has allowed additional convenience methods in the MiniSolrCloudCluster including: Upload a config directory to ZooKeeper Create a collection Added ability to provide collection properties Use a pre-configured CloudSolrServer instance The TestMiniSolrCloudCluster has been refactored to use these new methods. A few additional changes that should still be done: Provide waitForRecoveriesToFinish convenience method in MiniSolrCloudCluster The code in the test is almost a direct copy/past from AbstractDistribZkTestBase.waitForRecoveriesToFinish, it would be nice to refactor this code into a common class (as this is not trivial code to maintain). All system properties were dropped except for solr.solrxml.location & zkHost because those are necessary for Jetty to know where to pick up it's configuration on initial startup. It would be nice to see if there is an alternate way of getting that information to Jetty without setting the system property.
        Hide
        Erick Erickson added a comment -

        Patch with changes necessary for the CloudSolrServer <- CloudSolrClient changes, plus CHANGES.txt

        Thanks David!

        Show
        Erick Erickson added a comment - Patch with changes necessary for the CloudSolrServer <- CloudSolrClient changes, plus CHANGES.txt Thanks David!
        Hide
        ASF subversion and git services added a comment -

        Commit 1648923 from Erick Erickson in branch 'dev/trunk'
        [ https://svn.apache.org/r1648923 ]

        SOLR-6483, Refactor some methods in MiniSolrCloudCluster tests

        Show
        ASF subversion and git services added a comment - Commit 1648923 from Erick Erickson in branch 'dev/trunk' [ https://svn.apache.org/r1648923 ] SOLR-6483 , Refactor some methods in MiniSolrCloudCluster tests
        Hide
        ASF subversion and git services added a comment -

        Commit 1648938 from Erick Erickson in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1648938 ]

        SOLR-6483, Refactor some methods in MiniSolrCloudCluster tests

        Show
        ASF subversion and git services added a comment - Commit 1648938 from Erick Erickson in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1648938 ] SOLR-6483 , Refactor some methods in MiniSolrCloudCluster tests
        Hide
        Erick Erickson added a comment -

        Thanks David! There's doubtless more that we can do here, but my need evaporated. We can open other JIRAs as necessary.

        Also fixed bad EOL for some other checkin (RequestParmas and BlobStoreTestRequestHandlerV2)

        Show
        Erick Erickson added a comment - Thanks David! There's doubtless more that we can do here, but my need evaporated. We can open other JIRAs as necessary. Also fixed bad EOL for some other checkin (RequestParmas and BlobStoreTestRequestHandlerV2)
        Hide
        Anshum Gupta added a comment -

        Bulk close after 5.0 release.

        Show
        Anshum Gupta added a comment - Bulk close after 5.0 release.

          People

          • Assignee:
            Erick Erickson
            Reporter:
            Erick Erickson
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development