Solr
  1. Solr
  2. SOLR-6481

CLUSTERSTATUS action should consult /live_nodes when reporting the state of a replica

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.10.4, 5.0
    • Component/s: SolrCloud
    • Labels:
      None

      Description

      CLUSTERSTATUS action reports the state of replicas but it doesn't check /live_nodes, which means it might show a replica as "active" but the node is down, so the real state is "down".

      Ideally, we need a helper method that gets replica status that consults live nodes so this error doesn't keep cropping up all over the code base.

      1. SOLR-6481.patch
        3 kB
        Timothy Potter

        Activity

        Hide
        Timothy Potter added a comment -

        Here's a patch that cross-checks the replica state with live nodes. Since the code just uses the /clusterstate.json JSON map directly, I took the approach of walking the tree to check replica status.

        Show
        Timothy Potter added a comment - Here's a patch that cross-checks the replica state with live nodes. Since the code just uses the /clusterstate.json JSON map directly, I took the approach of walking the tree to check replica status.
        Hide
        ASF subversion and git services added a comment -

        Commit 1626818 from Timothy Potter in branch 'dev/trunk'
        [ https://svn.apache.org/r1626818 ]

        SOLR-6481: CLUSTERSTATUS action should consult /live_nodes when reporting the state of a replica

        Show
        ASF subversion and git services added a comment - Commit 1626818 from Timothy Potter in branch 'dev/trunk' [ https://svn.apache.org/r1626818 ] SOLR-6481 : CLUSTERSTATUS action should consult /live_nodes when reporting the state of a replica
        Hide
        ASF subversion and git services added a comment -

        Commit 1626828 from Timothy Potter in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1626828 ]

        SOLR-6481: CLUSTERSTATUS action should consult /live_nodes when reporting the state of a replica

        Show
        ASF subversion and git services added a comment - Commit 1626828 from Timothy Potter in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1626828 ] SOLR-6481 : CLUSTERSTATUS action should consult /live_nodes when reporting the state of a replica
        Hide
        Anshum Gupta added a comment -

        Bulk close after 5.0 release.

        Show
        Anshum Gupta added a comment - Bulk close after 5.0 release.
        Hide
        Shalin Shekhar Mangar added a comment -

        Reopening to backport to 4.10.4

        Show
        Shalin Shekhar Mangar added a comment - Reopening to backport to 4.10.4
        Hide
        ASF subversion and git services added a comment -

        Commit 1662428 from shalin@apache.org in branch 'dev/branches/lucene_solr_4_10'
        [ https://svn.apache.org/r1662428 ]

        SOLR-6481: CLUSTERSTATUS action should consult /live_nodes when reporting the state of a replica

        Show
        ASF subversion and git services added a comment - Commit 1662428 from shalin@apache.org in branch 'dev/branches/lucene_solr_4_10' [ https://svn.apache.org/r1662428 ] SOLR-6481 : CLUSTERSTATUS action should consult /live_nodes when reporting the state of a replica
        Hide
        Michael McCandless added a comment -

        Bulk close for 4.10.4 release

        Show
        Michael McCandless added a comment - Bulk close for 4.10.4 release

          People

          • Assignee:
            Timothy Potter
            Reporter:
            Timothy Potter
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development