[SOLR-6457] LBHttpSolrServer: AIOOBE risk if counter overflows

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.0, 4.1, 4.2, 4.2.1, 4.3, 4.3.1, 4.4, 4.5, 4.5.1, 4.6, 4.6.1, 4.7, 4.7.1, 4.7.2, 4.8, 4.8.1, 4.9
• Fix Version/s: 4.10.4, 5.0, 6.0
• Component/s: clients - java
• Labels: patch
• Assignee: Noble Paul
• Reporter: longkeyy
• Created: 31/Aug/14 16:39
• Updated: 09/May/16 18:57
• Resolved: 26/Feb/15 11:54

Description

org.apache.solr.client.solrj.impl.LBHttpSolrServer
line 442
int count = counter.incrementAndGet();
ServerWrapper wrapper = serverList[count % serverList.length];

when counter overflows, the mod operation of
"count % serverList.length" will start trying to use negative numbers as array indexes.

suggess to fixup it ,eg:
//keep count is greater than 0
int count = counter.incrementAndGet() & 0x7FFFFFF;