Solr
  1. Solr
  2. SOLR-639

Upgrade solr-ruby's XML capabilities for newest release of LibXML

    Details

    • Type: New Feature New Feature
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Won't Fix
    • Affects Version/s: 1.3
    • Fix Version/s: None
    • Component/s: clients - ruby - flare
    • Labels:
      None

      Description

      From an e-mail from José Valim:

      http://cfis.savagexi.com/articles/2008/07/16/resurrecting-libxml-ruby

      But since they prepend LibXML in everything, we have to make a couple changes to let it working:

      In the file: gems/solr-ruby-0.0.6/lib/solr/xml.rb

      Change line 23:

      class XML::Node

      For:

      class LibXML::XML::Node

      And then line 39:

      Solr::XML::Element = XML::Node

      For:

      Solr::XML::Element = LibXML::XML::Node

      1. solr_libxml.patch
        0.9 kB
        José Valim

        Activity

        Hide
        Erik Hatcher added a comment -

        solr-ruby has been "retired" to <https://github.com/erikhatcher/solr-ruby-flare/tree/master/solr-ruby>. RSolr is what the young whippersnappers use these days.

        Show
        Erik Hatcher added a comment - solr-ruby has been "retired" to < https://github.com/erikhatcher/solr-ruby-flare/tree/master/solr-ruby >. RSolr is what the young whippersnappers use these days.
        Hide
        José Valim added a comment -

        Patch attached!

        I've tested it against all possible scenarios, i.e.:

        1. Using only ReXML
        2. Using libxml-ruby before 0.8 (in the case, 0.6.0)
        3. And against the latest version of libxml (in the case, 0.8.1)

        Worked like a charm!

        Show
        José Valim added a comment - Patch attached! I've tested it against all possible scenarios, i.e.: 1. Using only ReXML 2. Using libxml-ruby before 0.8 (in the case, 0.6.0) 3. And against the latest version of libxml (in the case, 0.8.1) Worked like a charm!
        Hide
        Erik Hatcher added a comment -

        Keep this working with the current LibXML version support, as well as REXML

        Show
        Erik Hatcher added a comment - Keep this working with the current LibXML version support, as well as REXML

          People

          • Assignee:
            Erik Hatcher
            Reporter:
            Erik Hatcher
          • Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development