Solr
  1. Solr
  2. SOLR-6370

Allow tests to report/fail on many ZK watches being parallelly requested on the same data

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.0
    • Component/s: Tests
    • Labels:
      None

      Description

      Issues like SOLR-6336 uncovered cases where we were using too many ZK watches. Watches are costly and we should fix such places but there's no good way for tests to find out about them.

      This issue is for a mechanism for tests to report or fail on watches being redundantly set on data. This would also allow for specific tests to configure if there's a valid case for such a thing happening.

        Activity

        Hide
        ASF GitHub Bot added a comment -

        GitHub user andyetitmoves opened a pull request:

        https://github.com/apache/lucene-solr/pull/84

        Allow tests to report/fail on many ZK watches being parallelly requested on the same data

        Initial patch for SOLR-6370, starts off with conservative defaults (just show report at shutdown), but could be made stricter as we fix up issues this uncovers (there are lots which do show up).

        I opted to implement this on the server side so that the real SolrZkClient doesn't have to be modified for tests, and all tests are opted in by default.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/bloomberg/lucene-solr trunk-latch-qc

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/lucene-solr/pull/84.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #84


        commit 86546e224cf5bf11f85dc081d4d3aaa13a93685f
        Author: Ramkumar Aiyengar <andyetitmoves@gmail.com>
        Date: 2014-08-12T05:02:31Z

        Allow tests to report/fail on many ZK watches being parallelly requested on the same data


        Show
        ASF GitHub Bot added a comment - GitHub user andyetitmoves opened a pull request: https://github.com/apache/lucene-solr/pull/84 Allow tests to report/fail on many ZK watches being parallelly requested on the same data Initial patch for SOLR-6370 , starts off with conservative defaults (just show report at shutdown), but could be made stricter as we fix up issues this uncovers (there are lots which do show up). I opted to implement this on the server side so that the real SolrZkClient doesn't have to be modified for tests, and all tests are opted in by default. You can merge this pull request into a Git repository by running: $ git pull https://github.com/bloomberg/lucene-solr trunk-latch-qc Alternatively you can review and apply these changes as the patch at: https://github.com/apache/lucene-solr/pull/84.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #84 commit 86546e224cf5bf11f85dc081d4d3aaa13a93685f Author: Ramkumar Aiyengar <andyetitmoves@gmail.com> Date: 2014-08-12T05:02:31Z Allow tests to report/fail on many ZK watches being parallelly requested on the same data
        Hide
        ASF subversion and git services added a comment -

        Commit 1626253 from Timothy Potter in branch 'dev/trunk'
        [ https://svn.apache.org/r1626253 ]

        SOLR-6370: Allow tests to report/fail on many ZK watches being parallelly requested on the same data (This closes #84)

        Show
        ASF subversion and git services added a comment - Commit 1626253 from Timothy Potter in branch 'dev/trunk' [ https://svn.apache.org/r1626253 ] SOLR-6370 : Allow tests to report/fail on many ZK watches being parallelly requested on the same data (This closes #84)
        Hide
        ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/lucene-solr/pull/84

        Show
        ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/lucene-solr/pull/84
        Hide
        Mark Miller added a comment -

        Hey Timothy Potter, have you finished this one? Looks like one commit to trunk, unassigned, and still open?

        Show
        Mark Miller added a comment - Hey Timothy Potter , have you finished this one? Looks like one commit to trunk, unassigned, and still open?
        Hide
        Mark Miller added a comment -

        Timothy Potter, is there a reason this did not go to 5x, or was it just missed?

        Show
        Mark Miller added a comment - Timothy Potter , is there a reason this did not go to 5x, or was it just missed?
        Hide
        Timothy Potter added a comment -

        Originally, I wanted to see how it worked in trunk but then slipped through the cracks. I can get it back-ported to 5x in the next couple of days.

        Show
        Timothy Potter added a comment - Originally, I wanted to see how it worked in trunk but then slipped through the cracks. I can get it back-ported to 5x in the next couple of days.
        Hide
        Mark Miller added a comment -

        Thanks! I'm working on a list of Ram's open issues and I keep coming back to this because its still open.

        Show
        Mark Miller added a comment - Thanks! I'm working on a list of Ram's open issues and I keep coming back to this because its still open.
        Hide
        ASF subversion and git services added a comment -

        Commit 1642180 from Timothy Potter in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1642180 ]

        SOLR-6370: Allow tests to report/fail on many ZK watches being parallelly requested on the same data

        Show
        ASF subversion and git services added a comment - Commit 1642180 from Timothy Potter in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1642180 ] SOLR-6370 : Allow tests to report/fail on many ZK watches being parallelly requested on the same data
        Hide
        ASF subversion and git services added a comment -

        Commit 1642181 from Timothy Potter in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1642181 ]

        SOLR-6370: oops, put wrong jira # in changes.txt

        Show
        ASF subversion and git services added a comment - Commit 1642181 from Timothy Potter in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1642181 ] SOLR-6370 : oops, put wrong jira # in changes.txt
        Hide
        ASF subversion and git services added a comment -

        Commit 1642182 from Timothy Potter in branch 'dev/trunk'
        [ https://svn.apache.org/r1642182 ]

        SOLR-6370: mention in changes

        Show
        ASF subversion and git services added a comment - Commit 1642182 from Timothy Potter in branch 'dev/trunk' [ https://svn.apache.org/r1642182 ] SOLR-6370 : mention in changes
        Hide
        Anshum Gupta added a comment -

        Bulk close after 5.0 release.

        Show
        Anshum Gupta added a comment - Bulk close after 5.0 release.

          People

          • Assignee:
            Timothy Potter
            Reporter:
            Ramkumar Aiyengar
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development