[SOLR-6369] duplicate json key "echoParams" should be removed in ping-response

• Type: Bug
• Status: Resolved
• Priority: Trivial
• Resolution: Not A Problem
• Affects Version/s: 4.9

Environment

testing on ubuntu 14.04
version: 4.9.0 1604085 - rmuir - 2014-06-20 06:34:03

• Assignee: Unassigned
• Reporter: Marc Portier
• Created: 13/Aug/14 11:26
• Updated: 06/Jan/15 01:23
• Resolved: 13/Aug/14 16:54

Description

Apparently the /admin/ping handler will duplicate the echoParams key in the json-response.

$ curl -s http://localhost:8983/solr/test-node-client/admin/ping?wt=json
{"responseHeader":{"status":0,"QTime":2,"params":{"df":"text","echoParams":"all","rows":"10","echoParams":"all","wt":"json","q":"solrpingquery","distrib":"false"}},"status":"OK"}

Having "echoParams":"all" twice in that response doesn't really make sense?

Strictly speaking this is allowed in the json spec, so it is not a violation in principle
http://stackoverflow.com/questions/21832701/does-json-syntax-allow-duplicate-keys-in-an-object

However there are some json-parse implementations out there that want to map this into hashtables and are not silently overwriting the key with the last seen value, but are throwing errors in the process.

To those a cleanup of the json response would make life somewhat easier.

Issue Links

• relates to: SOLR-6780 some param values are duplicated when they override defaults, or are combined with appends values, or are an invariant that overrides a request param