Solr
  1. Solr
  2. SOLR-6358

Remove VcsDirectoryMappings from idea configuration vcs.xml

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.10, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      Idea detects and sets this correctly anyway. Currently ant idea copies a file which specifies the VCS mapping to be SVN, which ends up not that working well when cloning using the Git mirror. Will attach a patch which removes the section.

        Activity

        Hide
        Ramkumar Aiyengar added a comment -

        The patch is at https://github.com/apache/lucene-solr/pull/82

        (for some reason the bot hasn't posted it so far..)

        Show
        Ramkumar Aiyengar added a comment - The patch is at https://github.com/apache/lucene-solr/pull/82 (for some reason the bot hasn't posted it so far..)
        Hide
        Steve Rowe added a comment -

        Idea detects and sets this correctly anyway.

        I'm pretty sure this wasn't always so (hence the inclusion of VcsDirectoryMappings in the config template), but I tested it with IntelliJ IDEA 13.1, and both Subversion and Git are properly detected if VcsDirectoryMappings is not present in .idea/vcs.xml, and then VcsDirectoryMappings is automatically added to .idea/vcs.xml.

        I'll commit shortly.

        Show
        Steve Rowe added a comment - Idea detects and sets this correctly anyway. I'm pretty sure this wasn't always so (hence the inclusion of VcsDirectoryMappings in the config template), but I tested it with IntelliJ IDEA 13.1, and both Subversion and Git are properly detected if VcsDirectoryMappings is not present in .idea/vcs.xml , and then VcsDirectoryMappings is automatically added to .idea/vcs.xml . I'll commit shortly.
        Hide
        ASF subversion and git services added a comment -

        Commit 1617031 from Use account "steve_rowe" instead in branch 'dev/trunk'
        [ https://svn.apache.org/r1617031 ]

        SOLR-6358: Remove VcsDirectoryMappings from idea configuration vcs.xml

        Show
        ASF subversion and git services added a comment - Commit 1617031 from Use account "steve_rowe" instead in branch 'dev/trunk' [ https://svn.apache.org/r1617031 ] SOLR-6358 : Remove VcsDirectoryMappings from idea configuration vcs.xml
        Hide
        ASF subversion and git services added a comment -

        Commit 1617032 from Use account "steve_rowe" instead in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1617032 ]

        SOLR-6358: Remove VcsDirectoryMappings from idea configuration vcs.xml (merged trunk r1617031; this closes #82)

        Show
        ASF subversion and git services added a comment - Commit 1617032 from Use account "steve_rowe" instead in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1617032 ] SOLR-6358 : Remove VcsDirectoryMappings from idea configuration vcs.xml (merged trunk r1617031; this closes #82)
        Hide
        Steve Rowe added a comment -

        Committed to trunk and branch_4x.

        Thanks Ramkumar!

        Show
        Steve Rowe added a comment - Committed to trunk and branch_4x. Thanks Ramkumar!

          People

          • Assignee:
            Steve Rowe
            Reporter:
            Ramkumar Aiyengar
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development