Solr
  1. Solr
  2. SOLR-6323

ReRankingQParserPlugin cleaner paging and fix bug with fuzzy, range and other queries that need to be re-written.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.9
    • Fix Version/s: 4.10.3, 5.0
    • Component/s: search
    • Labels:
      None

      Description

      Discussed in this thread: http://www.mail-archive.com/solr-user@lucene.apache.org/msg100870.html

      Currently the ReRankingQParserPlugin requires the client to drop the re-rank parameter during paging if it only wants the top N documents to be re-ranked and is getting past that N. This also requires that the N must fall on page borders.

      ReRankingQParserPlugin should provide transparency for the client by returning results beyond N in their regular (non-reranked) order.

      NOTE: This ticket also fixed a bug when the main query contained fuzzy, range and other queries that need to rewritten.

      1. SOLR-6323.patch
        21 kB
        Joel Bernstein
      2. SOLR-6323.patch
        16 kB
        Joel Bernstein
      3. SOLR-6323.patch
        14 kB
        Joel Bernstein
      4. SOLR-6323.patch
        11 kB
        Joel Bernstein

        Activity

        Hide
        Joel Bernstein added a comment - - edited

        First crack at a new paging implementation. Still needs more testing, especially the integration with QueryElevation

        Show
        Joel Bernstein added a comment - - edited First crack at a new paging implementation. Still needs more testing, especially the integration with QueryElevation
        Hide
        Joel Bernstein added a comment -

        Ok, this is looking much better then the original implementation and very close to complete. I plan on committing this in the next day or two unless someone sees an issue with the new implementation.

        Show
        Joel Bernstein added a comment - Ok, this is looking much better then the original implementation and very close to complete. I plan on committing this in the next day or two unless someone sees an issue with the new implementation.
        Hide
        ASF subversion and git services added a comment -

        Commit 1624303 from Joel Bernstein in branch 'dev/trunk'
        [ https://svn.apache.org/r1624303 ]

        SOLR-6323: ReRankingQParserPlugin should handle paging beyond number reranked

        Show
        ASF subversion and git services added a comment - Commit 1624303 from Joel Bernstein in branch 'dev/trunk' [ https://svn.apache.org/r1624303 ] SOLR-6323 : ReRankingQParserPlugin should handle paging beyond number reranked
        Hide
        ASF subversion and git services added a comment -

        Commit 1624386 from Joel Bernstein in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1624386 ]

        SOLR-6323: ReRankingQParserPlugin should handle paging beyond number reranked

        Show
        ASF subversion and git services added a comment - Commit 1624386 from Joel Bernstein in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1624386 ] SOLR-6323 : ReRankingQParserPlugin should handle paging beyond number reranked
        Hide
        ASF subversion and git services added a comment -

        Commit 1624394 from Joel Bernstein in branch 'dev/trunk'
        [ https://svn.apache.org/r1624394 ]

        SOLR-6323: changed overank combined query elevation test.

        Show
        ASF subversion and git services added a comment - Commit 1624394 from Joel Bernstein in branch 'dev/trunk' [ https://svn.apache.org/r1624394 ] SOLR-6323 : changed overank combined query elevation test.
        Hide
        ASF subversion and git services added a comment -

        Commit 1624395 from Joel Bernstein in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1624395 ]

        SOLR-6323: changed overank combined query elevation test.

        Show
        ASF subversion and git services added a comment - Commit 1624395 from Joel Bernstein in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1624395 ] SOLR-6323 : changed overank combined query elevation test.
        Hide
        ASF subversion and git services added a comment -

        Commit 1636735 from Joel Bernstein in branch 'dev/branches/lucene_solr_4_10'
        [ https://svn.apache.org/r1636735 ]

        SOLR-6323 ReRankingQParserPlugin should handle paging beyond number reranked

        Show
        ASF subversion and git services added a comment - Commit 1636735 from Joel Bernstein in branch 'dev/branches/lucene_solr_4_10' [ https://svn.apache.org/r1636735 ] SOLR-6323 ReRankingQParserPlugin should handle paging beyond number reranked
        Hide
        David Smiley added a comment -

        It's worth noting that this also fixed an unreported bug in which ReRankQuery was not propagating the rewrite call on the query, and thus fuzzy and other multi-term queries weren't working.

        Show
        David Smiley added a comment - It's worth noting that this also fixed an unreported bug in which ReRankQuery was not propagating the rewrite call on the query, and thus fuzzy and other multi-term queries weren't working.
        Hide
        Joel Bernstein added a comment -

        Agreed. I'll update the description on this ticket and also note this in the CHANGES.txt

        Show
        Joel Bernstein added a comment - Agreed. I'll update the description on this ticket and also note this in the CHANGES.txt
        Hide
        ASF subversion and git services added a comment -

        Commit 1640259 from Joel Bernstein in branch 'dev/trunk'
        [ https://svn.apache.org/r1640259 ]

        SOLR-6323: Updated CHANGES.txt

        Show
        ASF subversion and git services added a comment - Commit 1640259 from Joel Bernstein in branch 'dev/trunk' [ https://svn.apache.org/r1640259 ] SOLR-6323 : Updated CHANGES.txt
        Hide
        ASF subversion and git services added a comment -

        Commit 1640262 from Joel Bernstein in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1640262 ]

        SOLR-6323: Updated CHANGES.txt

        Show
        ASF subversion and git services added a comment - Commit 1640262 from Joel Bernstein in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1640262 ] SOLR-6323 : Updated CHANGES.txt
        Hide
        ASF subversion and git services added a comment -

        Commit 1640266 from Joel Bernstein in branch 'dev/branches/lucene_solr_4_10'
        [ https://svn.apache.org/r1640266 ]

        SOLR-6323: Updated CHANGES.txt

        Show
        ASF subversion and git services added a comment - Commit 1640266 from Joel Bernstein in branch 'dev/branches/lucene_solr_4_10' [ https://svn.apache.org/r1640266 ] SOLR-6323 : Updated CHANGES.txt
        Hide
        Anshum Gupta added a comment -

        Bulk close after 5.0 release.

        Show
        Anshum Gupta added a comment - Bulk close after 5.0 release.

          People

          • Assignee:
            Joel Bernstein
            Reporter:
            Adair Kovac
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development