Solr
  1. Solr
  2. SOLR-6279

cores?action=UNLOAD can unregister unclosed core

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.5, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      baseline:

        /somewhere/instanceA/collection1_shard1/core.properties
        /somewhere/instanceA/collection1_shard1/data
        /somewhere/instanceA/collection1_shard2/core.properties
        /somewhere/instanceA/collection1_shard2/data
      
        /somewhere/instanceB
      

      actions:

        curl "http://host:port/solr/admin/cores?action=UNLOAD&core=collection1_shard2"
      
        # since UNLOAD completed we should now be free to move the unloaded core's files as we wish
      
        mv /somewhere/instanceA/collection1_shard2 /somewhere/instanceB/collection1_shard2
      

      expected result:

        /somewhere/instanceA/collection1_shard1/core.properties
        /somewhere/instanceA/collection1_shard1/data
      
        # collection1_shard2 files have been fully relocated
      
        /somewhere/instanceB/collection1_shard2/core.properties.unloaded
        /somewhere/instanceB/collection1_shard2/data
      

      actual result:

        /somewhere/instanceA/collection1_shard1/core.properties
        /somewhere/instanceA/collection1_shard1/data
        /somewhere/instanceA/collection1_shard2/data
      
        # collection1_shard2 files have not been fully relocated and/or some files were left behind in instanceA because the UNLOAD action had returned prior to the core being closed
      
        /somewhere/instanceB/collection1_shard2/core.properties.unloaded
        /somewhere/instanceB/collection1_shard2/data
      

      proposed fix: Changing CoreContainer.unload to wait for core to close before unregistering it from ZK. Adding testMidUseUnload method to TestLazyCores.

        Activity

        Hide
        ASF GitHub Bot added a comment -

        GitHub user cpoerschke opened a pull request:

        https://github.com/apache/lucene-solr/pull/72

        SOLR-6279: cores?action=UNLOAD can unregister unclosed core

        https://issues.apache.org/jira/i#browse/SOLR-6279

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/bloomberg/lucene-solr trunk-UNLOAD-can-unregister-unclosed-close

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/lucene-solr/pull/72.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #72


        commit 2a80ca5dfb47b7cd0416be2ae72bade0fe8f3ad0
        Author: Christine Poerschke <cpoerschke@bloomberg.net>
        Date: 2014-07-22T12:07:58Z

        solr: cores?action=UNLOAD can unregister unclosed core

        Changing CoreContainer.unload to wait for core to close before unregistering it from ZK. Adding testMidUseUnload method to TestLazyCores.


        Show
        ASF GitHub Bot added a comment - GitHub user cpoerschke opened a pull request: https://github.com/apache/lucene-solr/pull/72 SOLR-6279 : cores?action=UNLOAD can unregister unclosed core https://issues.apache.org/jira/i#browse/SOLR-6279 You can merge this pull request into a Git repository by running: $ git pull https://github.com/bloomberg/lucene-solr trunk-UNLOAD-can-unregister-unclosed-close Alternatively you can review and apply these changes as the patch at: https://github.com/apache/lucene-solr/pull/72.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #72 commit 2a80ca5dfb47b7cd0416be2ae72bade0fe8f3ad0 Author: Christine Poerschke <cpoerschke@bloomberg.net> Date: 2014-07-22T12:07:58Z solr: cores?action=UNLOAD can unregister unclosed core Changing CoreContainer.unload to wait for core to close before unregistering it from ZK. Adding testMidUseUnload method to TestLazyCores.
        Hide
        Mark Miller added a comment -

        +1

        Show
        Mark Miller added a comment - +1
        Hide
        ASF subversion and git services added a comment -

        Commit 1724654 from Christine Poerschke in branch 'dev/trunk'
        [ https://svn.apache.org/r1724654 ]

        SOLR-6279: cores?action=UNLOAD now waits for the core to close before unregistering it from ZK.

        Show
        ASF subversion and git services added a comment - Commit 1724654 from Christine Poerschke in branch 'dev/trunk' [ https://svn.apache.org/r1724654 ] SOLR-6279 : cores?action=UNLOAD now waits for the core to close before unregistering it from ZK.
        Hide
        ASF subversion and git services added a comment -

        Commit 1724668 from Christine Poerschke in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1724668 ]

        SOLR-6279: cores?action=UNLOAD now waits for the core to close before unregistering it from ZK. (merge in revision 1724654 from trunk)

        Show
        ASF subversion and git services added a comment - Commit 1724668 from Christine Poerschke in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1724668 ] SOLR-6279 : cores?action=UNLOAD now waits for the core to close before unregistering it from ZK. (merge in revision 1724654 from trunk)

          People

          • Assignee:
            Christine Poerschke
            Reporter:
            Christine Poerschke
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development