Solr
  1. Solr
  2. SOLR-6269

Change "rollback" to "error" in DIH

    Details

      Description

      Since rollback (see SOLR-3622) is going away from DIH, at least in SolrCloud mode, let's rename most things "rollback" to "error", such as the new onRollback handler.

      1. SOLR-6269.patch
        10 kB
        Erik Hatcher

        Activity

        Hide
        Erik Hatcher added a comment -

        attached patch for trunk. This patch avoids calling the Solr rollback capability when in ZK mode (maybe this should be a tackled separately though)

        Show
        Erik Hatcher added a comment - attached patch for trunk. This patch avoids calling the Solr rollback capability when in ZK mode (maybe this should be a tackled separately though)
        Hide
        Noble Paul added a comment -

        Let's change this entity level onError to be an eventHandler which can be a java class or javascript function.

        Change the signature of EventListener.onEvent(..) to return an Object

        If the listener is implemented , it should return one of ABORT|CONTINUE|SKIP

        As of now it is an entity level attribute and we can leave it as it is

        The ctx.getLastException() should give the actual exception that happened

        Show
        Noble Paul added a comment - Let's change this entity level onError to be an eventHandler which can be a java class or javascript function. Change the signature of EventListener.onEvent(..) to return an Object If the listener is implemented , it should return one of ABORT|CONTINUE|SKIP As of now it is an entity level attribute and we can leave it as it is The ctx.getLastException() should give the actual exception that happened
        Hide
        Erik Hatcher added a comment -

        I think we should leave the entity level modifications to another ticket.

        Noble Paul What do you mean that lastException should give the actual exception that happened? Is that different than what's in my patch (other than a getter for the internal value could be added)? Is there a different exception that should be captured before this handler is called?

        Show
        Erik Hatcher added a comment - I think we should leave the entity level modifications to another ticket. Noble Paul What do you mean that lastException should give the actual exception that happened? Is that different than what's in my patch (other than a getter for the internal value could be added)? Is there a different exception that should be captured before this handler is called?
        Hide
        ASF subversion and git services added a comment -

        Commit 1613406 from Erik Hatcher in branch 'dev/trunk'
        [ https://svn.apache.org/r1613406 ]

        SOLR-3622, SOLR-5847, SOLR-6194, SOLR-6269: Several DIH fixes/improvements

        Show
        ASF subversion and git services added a comment - Commit 1613406 from Erik Hatcher in branch 'dev/trunk' [ https://svn.apache.org/r1613406 ] SOLR-3622 , SOLR-5847 , SOLR-6194 , SOLR-6269 : Several DIH fixes/improvements
        Hide
        ASF subversion and git services added a comment -

        Commit 1613409 from Erik Hatcher in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1613409 ]

        SOLR-3622, SOLR-5847, SOLR-6194, SOLR-6269: Several DIH fixes/improvements (merged from r1613406)

        Show
        ASF subversion and git services added a comment - Commit 1613409 from Erik Hatcher in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1613409 ] SOLR-3622 , SOLR-5847 , SOLR-6194 , SOLR-6269 : Several DIH fixes/improvements (merged from r1613406)
        Hide
        Noble Paul added a comment -

        I just went through the patch
        It's fine.

        Show
        Noble Paul added a comment - I just went through the patch It's fine.

          People

          • Assignee:
            Erik Hatcher
            Reporter:
            Erik Hatcher
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development