[SOLR-6252] A couple of small improvements to UnInvertedField class.

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 6.0
• Fix Version/s: 4.10, 6.0
• Component/s: search
• Assignee: Mark Miller
• Reporter: Vamsee K. Yarlagadda
• Created: 16/Jul/14 22:23
• Updated: 09/May/16 18:48
• Resolved: 22/Jul/14 15:10

Description

Looks like UnInvertedField#getUnInvertedField has implemented a bit additional synchronization module rather than what is required, and thereby increasing the complexity.

https://github.com/apache/lucene-solr/blob/trunk/solr/core/src/java/org/apache/solr/request/UnInvertedField.java#L667

As pointed out in the above link, as the synchronization is performed on the cache variable(which itself will protect the threads from obtaining access to the cache), we can safely remove all the placeholder flags. As long as cache.get() is in synchronized block, we can simply populate the cache with new entries and other threads will be able to see the changes.

This change has been introduced in https://issues.apache.org/jira/browse/SOLR-2548 (Multithreaded faceting)

Issue Links

• is related to: SOLR-6846 deadlock in UninvertedField#getUninvertedField()
• links to: Review Board