Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-6224

Post soft-commit callbacks are called before soft commit actually happens

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 4.9
    • Fix Version/s: 5.0, 6.0
    • Component/s: update
    • Labels:
      None

      Description

      DirectUpdateHandler2 has the following code:

      if (!cmd.softCommit) {
                synchronized (solrCoreState.getUpdateLock()) { // sync is currently needed to prevent preCommit
                                      // from being called between preSoft and
                                      // postSoft... see postSoft comments.
                  if (ulog != null) ulog.preCommit(cmd);
                }
                
                // SolrCore.verbose("writer.commit() start writer=",writer);
      
                if (writer.hasUncommittedChanges()) {
                  final Map<String,String> commitData = new HashMap<>();
                  commitData.put(SolrIndexWriter.COMMIT_TIME_MSEC_KEY,
                      String.valueOf(System.currentTimeMillis()));
                  writer.setCommitData(commitData);
                  writer.commit();
                } else {
                  log.info("No uncommitted changes. Skipping IW.commit.");
                }
      
                // SolrCore.verbose("writer.commit() end");
                numDocsPending.set(0);
                callPostCommitCallbacks();
              } else {
                callPostSoftCommitCallbacks();
              }
      

      As evident in the code above, if cmd.softCommit is true then the post soft commit hooks are called first and the actual soft commit happens in a block of code after it.

        Attachments

        1. SOLR-6224.patch
          4 kB
          Shalin Shekhar Mangar
        2. SOLR-6224.patch
          4 kB
          Shalin Shekhar Mangar

          Activity

            People

            • Assignee:
              shalinmangar Shalin Shekhar Mangar
              Reporter:
              shalinmangar Shalin Shekhar Mangar
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: