Solr
  1. Solr
  2. SOLR-6171

Remove SolrCores coreNameToOrig map

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.10
    • Component/s: None
    • Labels:
      None

      Description

      This doesn't appear to be used anywhere - I'm guessing it's a relic of the core aliasing code.

      1. SOLR-6171.patch
        8 kB
        Alan Woodward
      2. SOLR-6171.patch
        4 kB
        Alan Woodward

        Activity

        Hide
        Alan Woodward added a comment -

        Patch.

        Show
        Alan Woodward added a comment - Patch.
        Hide
        Alan Woodward added a comment -

        This actually allows us to clean up a whole bunch of core-load code. Here's an updated patch.

        One question - at the moment, we wait until all the cores are loaded before registering them as up in ZK. Is there a specific reason for doing this? It adds a bit of complexity to the code, and it would be good to at least add a comment explaining why it's necessary.

        Show
        Alan Woodward added a comment - This actually allows us to clean up a whole bunch of core-load code. Here's an updated patch. One question - at the moment, we wait until all the cores are loaded before registering them as up in ZK. Is there a specific reason for doing this? It adds a bit of complexity to the code, and it would be good to at least add a comment explaining why it's necessary.
        Hide
        Shalin Shekhar Mangar added a comment -

        One question - at the moment, we wait until all the cores are loaded before registering them as up in ZK. Is there a specific reason for doing this? It adds a bit of complexity to the code, and it would be good to at least add a comment explaining why it's necessary.

        This was done in SOLR-5552 from what I can find. It reduces the probability that a core is registered in ZK before it is able to serve HTTP requests.

        https://issues.apache.org/jira/browse/SOLR-5552?focusedCommentId=13855254&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13855254

        Show
        Shalin Shekhar Mangar added a comment - One question - at the moment, we wait until all the cores are loaded before registering them as up in ZK. Is there a specific reason for doing this? It adds a bit of complexity to the code, and it would be good to at least add a comment explaining why it's necessary. This was done in SOLR-5552 from what I can find. It reduces the probability that a core is registered in ZK before it is able to serve HTTP requests. https://issues.apache.org/jira/browse/SOLR-5552?focusedCommentId=13855254&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13855254
        Hide
        Alan Woodward added a comment -

        Ah right, because the HTTP connector won't start accepting connections until CoreContainer.load() has returned, and we wait for all cores to startup before returning.

        It would be nice to return immediately and let the cores load in the background, registering themselves as they appear - that way the first cores to load aren't waiting on later ones. But that's probably a matter for another issue.

        Show
        Alan Woodward added a comment - Ah right, because the HTTP connector won't start accepting connections until CoreContainer.load() has returned, and we wait for all cores to startup before returning. It would be nice to return immediately and let the cores load in the background, registering themselves as they appear - that way the first cores to load aren't waiting on later ones. But that's probably a matter for another issue.
        Hide
        ASF subversion and git services added a comment -

        Commit 1606918 from Alan Woodward in branch 'dev/trunk'
        [ https://svn.apache.org/r1606918 ]

        SOLR-6171: Remove SolrCores coreNameToOrig map

        Show
        ASF subversion and git services added a comment - Commit 1606918 from Alan Woodward in branch 'dev/trunk' [ https://svn.apache.org/r1606918 ] SOLR-6171 : Remove SolrCores coreNameToOrig map
        Hide
        ASF subversion and git services added a comment -

        Commit 1606924 from Alan Woodward in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1606924 ]

        SOLR-6171: Remove SolrCores coreNameToOrig map

        Show
        ASF subversion and git services added a comment - Commit 1606924 from Alan Woodward in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1606924 ] SOLR-6171 : Remove SolrCores coreNameToOrig map

          People

          • Assignee:
            Alan Woodward
            Reporter:
            Alan Woodward
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development