Solr
  1. Solr
  2. SOLR-6170

Merge 'pre-register', 'create' and 'register' core methods in CoreContainer

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 4.8.1, 6.0
    • Fix Version/s: 4.10
    • Component/s: None
    • Labels:
      None

      Description

      We have a bunch of duplicated logic in CoreContainer startup, CoreAdminHandler core creation and core tests that always calls the same three methods, 'preRegisterInZk', 'create' and 'register'. These should really all be in one API call.

      1. SOLR-6170.patch
        29 kB
        Alan Woodward
      2. SOLR-6170.patch
        26 kB
        Alan Woodward

        Activity

        Hide
        Alan Woodward added a comment -

        Patch moving the pre-register and register logic into CoreContainer.create(). Also does a bit of related method cleanup: the isTransient parameter to register can be read from the CoreDescriptor, and 'returnPrevNotClosed' was false everywhere the method was called.

        Show
        Alan Woodward added a comment - Patch moving the pre-register and register logic into CoreContainer.create(). Also does a bit of related method cleanup: the isTransient parameter to register can be read from the CoreDescriptor, and 'returnPrevNotClosed' was false everywhere the method was called.
        Hide
        Alan Woodward added a comment -

        Slightly amended patch, also removing the 'preRegisterInZk' method on CoreContainer, as that's now always done by create().

        Show
        Alan Woodward added a comment - Slightly amended patch, also removing the 'preRegisterInZk' method on CoreContainer, as that's now always done by create().
        Hide
        ASF subversion and git services added a comment -

        Commit 1606891 from Alan Woodward in branch 'dev/trunk'
        [ https://svn.apache.org/r1606891 ]

        SOLR-6170: Merge CoreContainer preRegisterInZk and register methods into create method

        Show
        ASF subversion and git services added a comment - Commit 1606891 from Alan Woodward in branch 'dev/trunk' [ https://svn.apache.org/r1606891 ] SOLR-6170 : Merge CoreContainer preRegisterInZk and register methods into create method
        Hide
        ASF subversion and git services added a comment -

        Commit 1606903 from Alan Woodward in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1606903 ]

        SOLR-6170: Merge CoreContainer preRegisterInZk and register methods into create method

        Show
        ASF subversion and git services added a comment - Commit 1606903 from Alan Woodward in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1606903 ] SOLR-6170 : Merge CoreContainer preRegisterInZk and register methods into create method

          People

          • Assignee:
            Alan Woodward
            Reporter:
            Alan Woodward
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development