Solr
  1. Solr
  2. SOLR-6169

Really really remove ALIAS command

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 4.8.1, 6.0
    • Fix Version/s: 5.0, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      The core admin ALIAS command was deprecated by SOLR-1637, in 2009. The method is, however, still there, marked as deprecated, five years later. It can probably be removed now...

      1. SOLR-6169.patch
        1 kB
        Alan Woodward

        Activity

        Hide
        Alan Woodward added a comment -

        In trunk we can just delete the method (it's not actually called from anywhere). In 4.x removing it would break binary compatibility for any plugin classes that extend CoreAdminHandler, so I propose to make the method just throw UnsupportedOperationException. As far as I can tell the code that's actually there is untested and broken anyway, so nobody should be using it.

        Show
        Alan Woodward added a comment - In trunk we can just delete the method (it's not actually called from anywhere). In 4.x removing it would break binary compatibility for any plugin classes that extend CoreAdminHandler, so I propose to make the method just throw UnsupportedOperationException. As far as I can tell the code that's actually there is untested and broken anyway, so nobody should be using it.
        Hide
        Alan Woodward added a comment -

        Trivial patch for trunk

        Show
        Alan Woodward added a comment - Trivial patch for trunk
        Hide
        Shalin Shekhar Mangar added a comment -

        In trunk we can just delete the method (it's not actually called from anywhere). In 4.x removing it would break binary compatibility for any plugin classes that extend CoreAdminHandler, so I propose to make the method just throw UnsupportedOperationException

        +1

        Show
        Shalin Shekhar Mangar added a comment - In trunk we can just delete the method (it's not actually called from anywhere). In 4.x removing it would break binary compatibility for any plugin classes that extend CoreAdminHandler, so I propose to make the method just throw UnsupportedOperationException +1
        Hide
        ASF subversion and git services added a comment -

        Commit 1602825 from Alan Woodward in branch 'dev/trunk'
        [ https://svn.apache.org/r1602825 ]

        SOLR-6169: Properly remove deprecated CoreAdminHandler handleAlias action

        Show
        ASF subversion and git services added a comment - Commit 1602825 from Alan Woodward in branch 'dev/trunk' [ https://svn.apache.org/r1602825 ] SOLR-6169 : Properly remove deprecated CoreAdminHandler handleAlias action
        Hide
        ASF subversion and git services added a comment -

        Commit 1602830 from Alan Woodward in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1602830 ]

        SOLR-6169: Remove broken CoreAdminHandler handleAlias action

        Show
        ASF subversion and git services added a comment - Commit 1602830 from Alan Woodward in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1602830 ] SOLR-6169 : Remove broken CoreAdminHandler handleAlias action
        Hide
        ASF subversion and git services added a comment -

        Commit 1603656 from hossman@apache.org in branch 'dev/trunk'
        [ https://svn.apache.org/r1603656 ]

        SOLR-6169: cleanup CHANGES.txt

        Show
        ASF subversion and git services added a comment - Commit 1603656 from hossman@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1603656 ] SOLR-6169 : cleanup CHANGES.txt
        Hide
        Anshum Gupta added a comment -

        Bulk close after 5.0 release.

        Show
        Anshum Gupta added a comment - Bulk close after 5.0 release.

          People

          • Assignee:
            Alan Woodward
            Reporter:
            Alan Woodward
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development