Solr
  1. Solr
  2. SOLR-6125

add SolrConfig/updateHandler/indexWriter/closeWaitsForMerges=FALSE support

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      The problem we saw was slow stopping of the overseer solr instance because it was in the middle of a big merge.

        Issue Links

          Activity

          Hide
          ASF GitHub Bot added a comment -

          GitHub user cpoerschke opened a pull request:

          https://github.com/apache/lucene-solr/pull/55

          add SolrConfig/updateHandler/indexWriter/closeWaitsForMerges=FALSE support

          For https://issues.apache.org/jira/i#browse/SOLR-6125 ticket.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/bloomberg/lucene-solr trunk-closeWaitsForMerges

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/lucene-solr/pull/55.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #55


          commit d8e6b676b9b3f5b8e9767a2e8b266d17a01d92f5
          Author: Christine Poerschke <cpoerschke@bloomberg.net>
          Date: 2014-05-30T08:32:50Z

          solr: add SolrConfig/updateHandler/indexWriter/closeWaitsForMerges=FALSE support


          Show
          ASF GitHub Bot added a comment - GitHub user cpoerschke opened a pull request: https://github.com/apache/lucene-solr/pull/55 add SolrConfig/updateHandler/indexWriter/closeWaitsForMerges=FALSE support For https://issues.apache.org/jira/i#browse/SOLR-6125 ticket. You can merge this pull request into a Git repository by running: $ git pull https://github.com/bloomberg/lucene-solr trunk-closeWaitsForMerges Alternatively you can review and apply these changes as the patch at: https://github.com/apache/lucene-solr/pull/55.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #55 commit d8e6b676b9b3f5b8e9767a2e8b266d17a01d92f5 Author: Christine Poerschke <cpoerschke@bloomberg.net> Date: 2014-05-30T08:32:50Z solr: add SolrConfig/updateHandler/indexWriter/closeWaitsForMerges=FALSE support
          Hide
          ASF subversion and git services added a comment -

          Commit 1603600 from Alan Woodward in branch 'dev/trunk'
          [ https://svn.apache.org/r1603600 ]

          SOLR-6125: Allow SolrIndexWriter to close without waiting for merges

          Show
          ASF subversion and git services added a comment - Commit 1603600 from Alan Woodward in branch 'dev/trunk' [ https://svn.apache.org/r1603600 ] SOLR-6125 : Allow SolrIndexWriter to close without waiting for merges
          Hide
          ASF subversion and git services added a comment -

          Commit 1603601 from Alan Woodward in branch 'dev/branches/branch_4x'
          [ https://svn.apache.org/r1603601 ]

          SOLR-6125: Allow SolrIndexWriter to close without waiting for merges

          Show
          ASF subversion and git services added a comment - Commit 1603601 from Alan Woodward in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1603601 ] SOLR-6125 : Allow SolrIndexWriter to close without waiting for merges
          Hide
          ASF subversion and git services added a comment -

          Commit 1603604 from Alan Woodward in branch 'dev/branches/lucene_solr_4_9'
          [ https://svn.apache.org/r1603604 ]

          SOLR-6125: Allow SolrIndexWriter to close without waiting for merges

          Show
          ASF subversion and git services added a comment - Commit 1603604 from Alan Woodward in branch 'dev/branches/lucene_solr_4_9' [ https://svn.apache.org/r1603604 ] SOLR-6125 : Allow SolrIndexWriter to close without waiting for merges
          Hide
          Alan Woodward added a comment -

          Committed to trunk, branch_4x and 4.9. Thanks Christine!

          Show
          Alan Woodward added a comment - Committed to trunk, branch_4x and 4.9. Thanks Christine!
          Hide
          Hoss Man added a comment -

          Why is there no test for this?

          And why was the xpath "updateHandler/indexWriter/closeWaitsForMerges" chosen for this? ... there has never been a "updateHandler/indexWriter" section before, and now there is but it only has a single setting under it? that seems weird.

          Show
          Hoss Man added a comment - Why is there no test for this? And why was the xpath "updateHandler/indexWriter/closeWaitsForMerges" chosen for this? ... there has never been a "updateHandler/indexWriter" section before, and now there is but it only has a single setting under it? that seems weird.
          Hide
          Hoss Man added a comment -

          This is already in 4.9, but i really think we should try to make it more consistent with the other configs options before 4.10.

          filed SOLR-6195 to try and do that.

          Show
          Hoss Man added a comment - This is already in 4.9, but i really think we should try to make it more consistent with the other configs options before 4.10. filed SOLR-6195 to try and do that.
          Hide
          ASF GitHub Bot added a comment -

          Github user cpoerschke closed the pull request at:

          https://github.com/apache/lucene-solr/pull/55

          Show
          ASF GitHub Bot added a comment - Github user cpoerschke closed the pull request at: https://github.com/apache/lucene-solr/pull/55

            People

            • Assignee:
              Alan Woodward
              Reporter:
              Christine Poerschke
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development