Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-6115

Cleanup enum/string action types in Overseer, OverseerCollectionProcessor and CollectionHandler

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.0, 6.0
    • Component/s: SolrCloud
    • Labels:
      None

      Description

      The enum/string handling for actions in Overseer and OCP is a mess. We should fix it.

      From: https://issues.apache.org/jira/browse/SOLR-5466?focusedCommentId=13918059&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13918059

      I started to untangle the fact that we have all the strings in OverseerCollectionProcessor, but also have a nice CollectionAction enum. And the commands are intermingled with parameters, it all seems rather confusing. Does it make sense to use the enum rather than the strings? Or somehow associate the two? Probably something for another JIRA though...

        Attachments

        1. SOLR-6115.patch
          59 kB
          Shalin Shekhar Mangar
        2. SOLR-6115-branch_4x.patch
          60 kB
          Shalin Shekhar Mangar

          Activity

            People

            • Assignee:
              shalin Shalin Shekhar Mangar
              Reporter:
              shalin Shalin Shekhar Mangar

              Dates

              • Created:
                Updated:
                Resolved:

                Issue deployment