Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-6090

Remove unreachable printLayout usage in cloud test

    XMLWordPrintableJSON

Details

    • Task
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 6.3, 7.0
    • SolrCloud, Tests
    • None

    Description

      Many cloud tests have a DEBUG instance variable e.g.

      private static final boolean DEBUG = false;
      

      and

      if (DEBUG) {
            super.printLayout();
      }
      

      I cannot find where this variable is set to true so the printLayout is never actually printed.

      We need to review and fix all such tests:

      1. BasicDistributedZKTest.doTest
      2. CollectionsAPIAsyncDistributedZkTest.doTest
      3. CollectionsAPIDistributedZkTest
      4. CustomCollectionTest
      5. UnloadDistributedZkTest

      This is not an exhaustive list.

      Attachments

        1. SOLR-6090.patch
          13 kB
          Cao Manh Dat

        Activity

          People

            caomanhdat Cao Manh Dat
            shalin Shalin Shekhar Mangar
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: