Solr
  1. Solr
  2. SOLR-6087

SolrIndexSearcher makes no DelegatingCollector.finish() call when IndexSearcher throws an expected exception.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.2, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      This seems like an omission. github pull request with proposed change to follow.

        Issue Links

          Activity

          Hide
          Christine Poerschke added a comment -
          Show
          Christine Poerschke added a comment - https://github.com/bloomberg/lucene-solr/pull/1 has proposed change.
          Hide
          ASF GitHub Bot added a comment -

          GitHub user cpoerschke opened a pull request:

          https://github.com/apache/lucene-solr/pull/57

          SolrIndexSearcher makes no DelegatingCollector.finish() call when ...

          SolrIndexSearcher makes no DelegatingCollector.finish() call when IndexSearcher throws an expected exception. This seems like an omission.

          This pull request is for https://issues.apache.org/jira/i#browse/SOLR-6087 re-baselined against trunk which now contains the SOLR-6067 refactor.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/bloomberg/lucene-solr trunk-solr-6087

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/lucene-solr/pull/57.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #57


          commit 6f16304a044307a37af58eb92361f8a0e20a5be1
          Author: Christine Poerschke <cpoerschke@bloomberg.net>
          Date: 2014-05-16T13:33:59Z

          solr: SolrIndexSearcher makes no DelegatingCollector.finish() call when IndexSearcher throws an expected exception. This seems like an omission.


          Show
          ASF GitHub Bot added a comment - GitHub user cpoerschke opened a pull request: https://github.com/apache/lucene-solr/pull/57 SolrIndexSearcher makes no DelegatingCollector.finish() call when ... SolrIndexSearcher makes no DelegatingCollector.finish() call when IndexSearcher throws an expected exception. This seems like an omission. This pull request is for https://issues.apache.org/jira/i#browse/SOLR-6087 re-baselined against trunk which now contains the SOLR-6067 refactor. You can merge this pull request into a Git repository by running: $ git pull https://github.com/bloomberg/lucene-solr trunk-solr-6087 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/lucene-solr/pull/57.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #57 commit 6f16304a044307a37af58eb92361f8a0e20a5be1 Author: Christine Poerschke <cpoerschke@bloomberg.net> Date: 2014-05-16T13:33:59Z solr: SolrIndexSearcher makes no DelegatingCollector.finish() call when IndexSearcher throws an expected exception. This seems like an omission.
          Hide
          Christine Poerschke added a comment -

          https://github.com/apache/lucene-solr/pull/57 is rebaselining against trunk which now contains SOLR-6067 refactor changes.

          An alternative change would be to have a 'finally' block which calls the 'finish()' method.

          However on the basis that exceptions other than TimeExceededException and EarlyTerminatingCollectorException may well have been caused or thrown by one of the collectors in the collector chain i think it's best to call finish only for known, expected code paths i.e. don't potentially call finish on a collector that is already in trouble. Also the 'finish()' method itself could throw.

          Show
          Christine Poerschke added a comment - https://github.com/apache/lucene-solr/pull/57 is rebaselining against trunk which now contains SOLR-6067 refactor changes. An alternative change would be to have a 'finally' block which calls the 'finish()' method. However on the basis that exceptions other than TimeExceededException and EarlyTerminatingCollectorException may well have been caused or thrown by one of the collectors in the collector chain i think it's best to call finish only for known, expected code paths i.e. don't potentially call finish on a collector that is already in trouble. Also the 'finish()' method itself could throw.
          Hide
          ASF subversion and git services added a comment -

          Commit 1674443 from shalin@apache.org in branch 'dev/trunk'
          [ https://svn.apache.org/r1674443 ]

          SOLR-6087: SolrIndexSearcher makes no DelegatingCollector.finish() call when IndexSearcher throws an expected exception. This closes #57.

          Show
          ASF subversion and git services added a comment - Commit 1674443 from shalin@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1674443 ] SOLR-6087 : SolrIndexSearcher makes no DelegatingCollector.finish() call when IndexSearcher throws an expected exception. This closes #57.
          Hide
          ASF subversion and git services added a comment -

          Commit 1674444 from shalin@apache.org in branch 'dev/branches/branch_5x'
          [ https://svn.apache.org/r1674444 ]

          SOLR-6087: SolrIndexSearcher makes no DelegatingCollector.finish() call when IndexSearcher throws an expected exception. This closes #57.

          Show
          ASF subversion and git services added a comment - Commit 1674444 from shalin@apache.org in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1674444 ] SOLR-6087 : SolrIndexSearcher makes no DelegatingCollector.finish() call when IndexSearcher throws an expected exception. This closes #57.
          Hide
          Shalin Shekhar Mangar added a comment -

          Thanks Christine!

          Show
          Shalin Shekhar Mangar added a comment - Thanks Christine!
          Hide
          ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/lucene-solr/pull/57

          Show
          ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/lucene-solr/pull/57
          Hide
          Anshum Gupta added a comment -

          Bulk close for 5.2.0.

          Show
          Anshum Gupta added a comment - Bulk close for 5.2.0.

            People

            • Assignee:
              Shalin Shekhar Mangar
              Reporter:
              Christine Poerschke
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development