Solr
  1. Solr
  2. SOLR-6017

SimpleQParser uses index analyzer instead of query analyzer

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.8.1, 4.9, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      The SimpleQParser uses getAnalyzer(), but it should be getQueryAnalyzer().

        Activity

        Hide
        Ryan Ernst added a comment -

        Patch with test.

        Show
        Ryan Ernst added a comment - Patch with test.
        Hide
        Erick Erickson added a comment -

        Gaahhhhh! What do people think about refactoring getAnalyzer() to getIndexAnalyzer()? This is trappy...

        Actually, since it's a public method I suppose we'd have to deprecate it and just have it call a new getIndexAnalyzer(). There's only 10 or so places it's called in Solr.....

        At least that way an IDE's autocomplete would give some clue that there even were two methods....

        Show
        Erick Erickson added a comment - Gaahhhhh! What do people think about refactoring getAnalyzer() to getIndexAnalyzer()? This is trappy... Actually, since it's a public method I suppose we'd have to deprecate it and just have it call a new getIndexAnalyzer(). There's only 10 or so places it's called in Solr..... At least that way an IDE's autocomplete would give some clue that there even were two methods....
        Hide
        Ryan Ernst added a comment -

        What do people think about refactoring getAnalyzer() to getIndexAnalyzer()? This is trappy...

        I completely agree. I created SOLR-6022 to address that.

        Show
        Ryan Ernst added a comment - What do people think about refactoring getAnalyzer() to getIndexAnalyzer()? This is trappy... I completely agree. I created SOLR-6022 to address that.
        Hide
        ASF subversion and git services added a comment -

        Commit 1590166 from Ryan Ernst in branch 'dev/trunk'
        [ https://svn.apache.org/r1590166 ]

        SOLR-6017: Fix SimpleQParser to use query analyzer instead of index analyzer

        Show
        ASF subversion and git services added a comment - Commit 1590166 from Ryan Ernst in branch 'dev/trunk' [ https://svn.apache.org/r1590166 ] SOLR-6017 : Fix SimpleQParser to use query analyzer instead of index analyzer
        Hide
        ASF subversion and git services added a comment -

        Commit 1590176 from Ryan Ernst in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1590176 ]

        SOLR-6017: Fix SimpleQParser to use query analyzer instead of index analyzer

        Show
        ASF subversion and git services added a comment - Commit 1590176 from Ryan Ernst in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1590176 ] SOLR-6017 : Fix SimpleQParser to use query analyzer instead of index analyzer
        Hide
        ASF subversion and git services added a comment -

        Commit 1591990 from Ryan Ernst in branch 'dev/branches/lucene_solr_4_8'
        [ https://svn.apache.org/r1591990 ]

        SOLR-6017: Fix SimpleQParser to use query analyzer instead of index analyzer

        Show
        ASF subversion and git services added a comment - Commit 1591990 from Ryan Ernst in branch 'dev/branches/lucene_solr_4_8' [ https://svn.apache.org/r1591990 ] SOLR-6017 : Fix SimpleQParser to use query analyzer instead of index analyzer
        Hide
        ASF subversion and git services added a comment -

        Commit 1592653 from Ryan Ernst in branch 'dev/branches/lucene_solr_4_8'
        [ https://svn.apache.org/r1592653 ]

        SOLR-6017: Update CHANGES.txt for 4.8.1

        Show
        ASF subversion and git services added a comment - Commit 1592653 from Ryan Ernst in branch 'dev/branches/lucene_solr_4_8' [ https://svn.apache.org/r1592653 ] SOLR-6017 : Update CHANGES.txt for 4.8.1

          People

          • Assignee:
            Ryan Ernst
            Reporter:
            Ryan Ernst
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development