Solr
  1. Solr
  2. SOLR-5999

Solr should expose setCheckIntegrityAtMerge in indexConfig

    Details

    • Type: New Feature New Feature
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.9, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      LUCENE-2446 added checksums to Lucene segment files. We could expose CheckIntegrityAtMerge in the indexConfig tag in solrconfig.xml.
      Something like -

           <!--
      		Use true to enable this safety check, which can help
         		reduce the risk of propagating index corruption from older segments 
         		into new ones, at the expense of slower merging.
           -->
           <checkIntegrityAtMerge>false</checkIntegrityAtMerge>
      
      1. SOLR-5999.patch
        5 kB
        Varun Thacker
      2. SOLR-5999.patch
        5 kB
        Varun Thacker

        Activity

        Hide
        Varun Thacker added a comment -

        Sorry for the extra noise, by mistake I pressed enter when I hadn't fully completed filing the Jira details.

        Show
        Varun Thacker added a comment - Sorry for the extra noise, by mistake I pressed enter when I hadn't fully completed filing the Jira details.
        Hide
        Ryan Ernst added a comment -

        Varun Thacker, do you plan to work on a patch?

        Show
        Ryan Ernst added a comment - Varun Thacker , do you plan to work on a patch?
        Hide
        Varun Thacker added a comment -

        Ryan Ernst Yes I would like to. I will work on it tomorrow and put up a patch. You could review it then.

        Show
        Varun Thacker added a comment - Ryan Ernst Yes I would like to. I will work on it tomorrow and put up a patch. You could review it then.
        Hide
        Varun Thacker added a comment -

        Patch adds checkIntegrityAtMerge option inside the indexConfig tag in the solrconfig.xml file.

        Show
        Varun Thacker added a comment - Patch adds checkIntegrityAtMerge option inside the indexConfig tag in the solrconfig.xml file.
        Hide
        Ryan Ernst added a comment -

        This looks great! Two minor comments on the test:

        • You don't need the @Test annotation
        • Your test function can throw Exception, instead of having try/catch.
        Show
        Ryan Ernst added a comment - This looks great! Two minor comments on the test: You don't need the @Test annotation Your test function can throw Exception, instead of having try/catch.
        Hide
        Erick Erickson added a comment -

        The @Test is the Junit4 way of doing things though, figuring out that it's a test due to the naming convention is the Junit3 way. Currently a matter of preference I admit...

        Show
        Erick Erickson added a comment - The @Test is the Junit4 way of doing things though, figuring out that it's a test due to the naming convention is the Junit3 way. Currently a matter of preference I admit...
        Hide
        Varun Thacker added a comment -

        Ryan Ernst Thanks for the review.

        Updated patch -
        1. throws Exception, instead of having try/catch.
        2. Personally I prefer the @Test annotation. It makes it more explicit that it's a test vs a helper method in the tests. I'm okay with either approach though.

        Show
        Varun Thacker added a comment - Ryan Ernst Thanks for the review. Updated patch - 1. throws Exception, instead of having try/catch. 2. Personally I prefer the @Test annotation. It makes it more explicit that it's a test vs a helper method in the tests. I'm okay with either approach though.
        Hide
        ASF subversion and git services added a comment -

        Commit 1589272 from Ryan Ernst in branch 'dev/trunk'
        [ https://svn.apache.org/r1589272 ]

        SOLR-5999: Add checkIntegrityAtMerge support to solrconfig.xml

        Show
        ASF subversion and git services added a comment - Commit 1589272 from Ryan Ernst in branch 'dev/trunk' [ https://svn.apache.org/r1589272 ] SOLR-5999 : Add checkIntegrityAtMerge support to solrconfig.xml
        Hide
        ASF subversion and git services added a comment -

        Commit 1589293 from Ryan Ernst in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1589293 ]

        SOLR-5999: Add checkIntegrityAtMerge support to solrconfig.xml

        Show
        ASF subversion and git services added a comment - Commit 1589293 from Ryan Ernst in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1589293 ] SOLR-5999 : Add checkIntegrityAtMerge support to solrconfig.xml
        Hide
        Ryan Ernst added a comment -

        Thanks Varun!

        Show
        Ryan Ernst added a comment - Thanks Varun!

          People

          • Assignee:
            Ryan Ernst
            Reporter:
            Varun Thacker
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development