Solr
  1. Solr
  2. SOLR-5974

Remove ShardDoc.score and use parent's ScoreDoc.score

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 4.8, 6.0
    • Fix Version/s: 4.9, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      ShardDoc.score is hiding ScoreDoc.score, it’s confusing and as it is package private it doesn’t allow custom components to read the scores of the resultIds after merge which can be useful

      1. SOLR-5974.patch
        2 kB
        Tomás Fernández Löbbe
      2. SOLR-5974.patch
        2 kB
        Tomás Fernández Löbbe

        Activity

        Hide
        Ryan Ernst added a comment -

        I think we should just remove the asserts that were checking for null now? Isn't NaN a "valid" score (should not error)?

        Show
        Ryan Ernst added a comment - I think we should just remove the asserts that were checking for null now? Isn't NaN a "valid" score (should not error)?
        Hide
        Tomás Fernández Löbbe added a comment -

        Yes, I think you are right.

        Show
        Tomás Fernández Löbbe added a comment - Yes, I think you are right.
        Hide
        ASF subversion and git services added a comment -

        Commit 1588580 from rjernst@apache.org in branch 'dev/trunk'
        [ https://svn.apache.org/r1588580 ]

        SOLR-5974: Remove ShardDoc.score and use parent's ScoreDoc.score

        Show
        ASF subversion and git services added a comment - Commit 1588580 from rjernst@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1588580 ] SOLR-5974 : Remove ShardDoc.score and use parent's ScoreDoc.score
        Hide
        ASF subversion and git services added a comment -

        Commit 1588593 from rjernst@apache.org in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1588593 ]

        SOLR-5974: Remove ShardDoc.score and use parent's ScoreDoc.score

        Show
        ASF subversion and git services added a comment - Commit 1588593 from rjernst@apache.org in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1588593 ] SOLR-5974 : Remove ShardDoc.score and use parent's ScoreDoc.score
        Hide
        Ryan Ernst added a comment -

        Thanks Tomás!

        Show
        Ryan Ernst added a comment - Thanks Tomás!

          People

          • Assignee:
            Ryan Ernst
            Reporter:
            Tomás Fernández Löbbe
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development