Solr
  1. Solr
  2. SOLR-5968

BinaryResponseWriter fetches unnecessary stored fields when only pseudo-fields are requested

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.10, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      If fl contains only pseudo fields, BinaryResponseWriter will load unnecessary stored fields before discarding them. The call to SolrIndexSearcher#doc(int i, Set<String> fields) can be skipped for this case.

      1. SOLR-5968.diff
        1 kB
        Gregg Donovan
      2. SOLR-5968-NOCOMMIT.diff
        4 kB
        Gregg Donovan

        Issue Links

          Activity

          Hide
          Gregg Donovan added a comment -

          Patch that optimizes the case of only pseudo fields being requested.

          Show
          Gregg Donovan added a comment - Patch that optimizes the case of only pseudo fields being requested.
          Hide
          Gregg Donovan added a comment -

          Patch that demonstrates the issue with a test. Not to be committed, just for demonstration purposes. I'm not sure how to factor this out into a committable test.

          Show
          Gregg Donovan added a comment - Patch that demonstrates the issue with a test. Not to be committed, just for demonstration purposes. I'm not sure how to factor this out into a committable test.
          Hide
          ASF subversion and git services added a comment -

          Commit 1612200 from shalin@apache.org in branch 'dev/trunk'
          [ https://svn.apache.org/r1612200 ]

          SOLR-5968: BinaryResponseWriter fetches unnecessary stored fields when only pseudo-fields are requested

          Show
          ASF subversion and git services added a comment - Commit 1612200 from shalin@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1612200 ] SOLR-5968 : BinaryResponseWriter fetches unnecessary stored fields when only pseudo-fields are requested
          Hide
          ASF subversion and git services added a comment -

          Commit 1612210 from shalin@apache.org in branch 'dev/branches/branch_4x'
          [ https://svn.apache.org/r1612210 ]

          SOLR-5968: BinaryResponseWriter fetches unnecessary stored fields when only pseudo-fields are requested

          Show
          ASF subversion and git services added a comment - Commit 1612210 from shalin@apache.org in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1612210 ] SOLR-5968 : BinaryResponseWriter fetches unnecessary stored fields when only pseudo-fields are requested
          Hide
          Shalin Shekhar Mangar added a comment -

          Thanks Gregg. I've committed your patch without the test. I can't quite figure out how to test it better either and this optimization is really useful.

          Show
          Shalin Shekhar Mangar added a comment - Thanks Gregg. I've committed your patch without the test. I can't quite figure out how to test it better either and this optimization is really useful.
          Hide
          Gregg Donovan added a comment -

          Thanks, Shalin!

          Show
          Gregg Donovan added a comment - Thanks, Shalin!
          Hide
          Mike Hugo added a comment -

          useful commit - however it appears to have introduced https://issues.apache.org/jira/browse/SOLR-6501

          Show
          Mike Hugo added a comment - useful commit - however it appears to have introduced https://issues.apache.org/jira/browse/SOLR-6501

            People

            • Assignee:
              Shalin Shekhar Mangar
              Reporter:
              Gregg Donovan
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development