Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-5954

Slower dataimport process caused by not reusing jdbc connections

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 4.7.1
    • Fix Version/s: 4.8, 6.0
    • Labels:
      None

      Description

      Hi,
      SOLR-5734 introduced a regression that causes that the connections used in the dataimport process were closed and reopen in every sql.

      The change to nanoTime in the method getConnection of JdbcDataSource.java forgot to convert the timeout used to reuse the connection.

      The constant CONN_TIME_OUT must be changed to nanos to be compared. (*1000*1000)

      private Connection getConnection() throws Exception {
      long currTime = System.nanoTime();
      if (currTime - connLastUsed > CONN_TIME_OUT)

      {<<<<<<<<<<<<<<< synchronized (this) { Connection tmpConn = factory.call(); closeConnection(); connLastUsed = System.nanoTime(); return conn = tmpConn; }

      } else

      { connLastUsed = currTime; return conn; }

      }

      private static final long CONN_TIME_OUT = 10 * 1000; // 10 seconds

      Regards

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                markrmiller@gmail.com Mark Miller
                Reporter:
                pacoge36 Paco Garcia
              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: