Solr
  1. Solr
  2. SOLR-5943

SolrCmdDistributor does not distribute the openSearcher parameter

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.6.1, 4.7
    • Fix Version/s: 4.8, 6.0
    • Component/s: update
    • Labels:
      None

      Description

      The openSearcher parameter in a commit command is totally ignored by the SolrCmdDistributor :

      SolrCmdDistributor.java
       void addCommit(UpdateRequest ureq, CommitUpdateCommand cmd) {
          if (cmd == null) return;
          ureq.setAction(cmd.optimize ? AbstractUpdateRequest.ACTION.OPTIMIZE
              : AbstractUpdateRequest.ACTION.COMMIT, false, cmd.waitSearcher, cmd.maxOptimizeSegments, cmd.softCommit, cmd.expungeDeletes);
        }

      I think the SolrJ API should take this parameter in account as well.

      1. SOLR-5943.patch
        4 kB
        Shalin Shekhar Mangar
      2. SOLR-5943.patch
        7 kB
        Ludovic Boutros

        Activity

        Hide
        Ludovic Boutros added a comment -

        A first small patch with unit test on branch lucene_solr_4_7.

        Show
        Ludovic Boutros added a comment - A first small patch with unit test on branch lucene_solr_4_7.
        Hide
        Shalin Shekhar Mangar added a comment -

        Thanks Ludovic.

        I reverted your changes to the public methods because we need to preserve back-compatibility. I added a new method which accepts a openSearcher boolean value instead. This patch applies to trunk. I'll commit shortly.

        Show
        Shalin Shekhar Mangar added a comment - Thanks Ludovic. I reverted your changes to the public methods because we need to preserve back-compatibility. I added a new method which accepts a openSearcher boolean value instead. This patch applies to trunk. I'll commit shortly.
        Hide
        ASF subversion and git services added a comment -

        Commit 1584083 from shalin@apache.org in branch 'dev/trunk'
        [ https://svn.apache.org/r1584083 ]

        SOLR-5943: SolrCmdDistributor does not distribute the openSearcher parameter

        Show
        ASF subversion and git services added a comment - Commit 1584083 from shalin@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1584083 ] SOLR-5943 : SolrCmdDistributor does not distribute the openSearcher parameter
        Hide
        ASF subversion and git services added a comment -

        Commit 1584084 from shalin@apache.org in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1584084 ]

        SOLR-5943: SolrCmdDistributor does not distribute the openSearcher parameter

        Show
        ASF subversion and git services added a comment - Commit 1584084 from shalin@apache.org in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1584084 ] SOLR-5943 : SolrCmdDistributor does not distribute the openSearcher parameter
        Hide
        Shalin Shekhar Mangar added a comment -

        Thanks Ludovic!

        Show
        Shalin Shekhar Mangar added a comment - Thanks Ludovic!
        Hide
        Ludovic Boutros added a comment -

        Excellent, thank you Shalin.

        Show
        Ludovic Boutros added a comment - Excellent, thank you Shalin.
        Hide
        Uwe Schindler added a comment -

        Close issue after release of 4.8.0

        Show
        Uwe Schindler added a comment - Close issue after release of 4.8.0

          People

          • Assignee:
            Shalin Shekhar Mangar
            Reporter:
            Ludovic Boutros
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development