Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-5934

LBHttpSolrServer exception handling improvement and small test improvements

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 4.8, 6.0
    • Fix Version/s: 4.8, 6.0
    • Component/s: SolrCloud
    • Labels:
      None

      Description

      The error handling in LBHttpSolrServer can be simplified – right now almost identical code is run whether the server is a zombie or not, which sometimes doesn't make complete sense. For example, the zombie code goes through some effort to throw an exception or save the exception based on the type of exception, but the end result is the same – an exception is thrown. It's simpler if the same code is run each time.

      Also, made some minor changes to test cases:

      • made sure SolrServer.shutdown is called in finally, so it happens even if a request throws an exception
      • got rid of some unnecessary checks
      • normalized some functions/variables so the functions are public scope and the variables aren't

        Attachments

        1. SOLR-5934.patch
          10 kB
          Gregory Chanan

          Activity

            People

            • Assignee:
              markrmiller@gmail.com Mark Miller
              Reporter:
              gchanan Gregory Chanan
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: