Solr
  1. Solr
  2. SOLR-5934

LBHttpSolrServer exception handling improvement and small test improvements

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 4.8, 6.0
    • Fix Version/s: 4.8, 6.0
    • Component/s: SolrCloud
    • Labels:
      None

      Description

      The error handling in LBHttpSolrServer can be simplified – right now almost identical code is run whether the server is a zombie or not, which sometimes doesn't make complete sense. For example, the zombie code goes through some effort to throw an exception or save the exception based on the type of exception, but the end result is the same – an exception is thrown. It's simpler if the same code is run each time.

      Also, made some minor changes to test cases:

      • made sure SolrServer.shutdown is called in finally, so it happens even if a request throws an exception
      • got rid of some unnecessary checks
      • normalized some functions/variables so the functions are public scope and the variables aren't
      1. SOLR-5934.patch
        10 kB
        Gregory Chanan

        Activity

        Hide
        ASF subversion and git services added a comment -

        Commit 1583213 from Mark Miller in branch 'dev/trunk'
        [ https://svn.apache.org/r1583213 ]

        SOLR-5934: LBHttpSolrServer exception handling improvement and small test improvements.

        Show
        ASF subversion and git services added a comment - Commit 1583213 from Mark Miller in branch 'dev/trunk' [ https://svn.apache.org/r1583213 ] SOLR-5934 : LBHttpSolrServer exception handling improvement and small test improvements.
        Hide
        ASF subversion and git services added a comment -

        Commit 1583214 from Mark Miller in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1583214 ]

        SOLR-5934: LBHttpSolrServer exception handling improvement and small test improvements.

        Show
        ASF subversion and git services added a comment - Commit 1583214 from Mark Miller in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1583214 ] SOLR-5934 : LBHttpSolrServer exception handling improvement and small test improvements.
        Hide
        Mark Miller added a comment -

        Thanks Greg!

        Show
        Mark Miller added a comment - Thanks Greg!
        Hide
        ASF subversion and git services added a comment -

        Commit 1583218 from Mark Miller in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1583218 ]

        SOLR-5934: Revert 4x commit.

        Show
        ASF subversion and git services added a comment - Commit 1583218 from Mark Miller in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1583218 ] SOLR-5934 : Revert 4x commit.
        Hide
        ASF subversion and git services added a comment -

        Commit 1583369 from Mark Miller in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1583369 ]

        SOLR-5934: Commit again to 4x - different JIRA caused the failes - LBHttpSolrServer exception handling improvement and small test improvements.

        Show
        ASF subversion and git services added a comment - Commit 1583369 from Mark Miller in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1583369 ] SOLR-5934 : Commit again to 4x - different JIRA caused the failes - LBHttpSolrServer exception handling improvement and small test improvements.
        Hide
        Uwe Schindler added a comment -

        Close issue after release of 4.8.0

        Show
        Uwe Schindler added a comment - Close issue after release of 4.8.0

          People

          • Assignee:
            Mark Miller
            Reporter:
            Gregory Chanan
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development