Solr
  1. Solr
  2. SOLR-592

Handler components should use parameter constants instead of hardcoded strings

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.3
    • Fix Version/s: None
    • Component/s: search
    • Labels:
      None

      Description

      Some classes in o.a.s.handler.component, namely QueryComponent, FacetComponent, and SearchHandler, use hardcoded strings to get/set parameters instead of using the constants defined in CommonParams.

        Issue Links

          Activity

          Hide
          Lars Kotthoff added a comment -

          Patch replacing the hardcoded strings with the proper constants. Also introduces o.a.s.common.params.ShardParams which holds the distributed search related parameter constants.

          Show
          Lars Kotthoff added a comment - Patch replacing the hardcoded strings with the proper constants. Also introduces o.a.s.common.params.ShardParams which holds the distributed search related parameter constants.
          Hide
          Otis Gospodnetic added a comment -

          Thank you Lars!

          Sending CHANGES.txt
          Adding src/java/org/apache/solr/common/params/ShardParams.java
          Sending src/java/org/apache/solr/handler/component/FacetComponent.java
          Sending src/java/org/apache/solr/handler/component/QueryComponent.java
          Sending src/java/org/apache/solr/handler/component/SearchHandler.java
          Transmitting file data .....
          Committed revision 667923.

          Show
          Otis Gospodnetic added a comment - Thank you Lars! Sending CHANGES.txt Adding src/java/org/apache/solr/common/params/ShardParams.java Sending src/java/org/apache/solr/handler/component/FacetComponent.java Sending src/java/org/apache/solr/handler/component/QueryComponent.java Sending src/java/org/apache/solr/handler/component/SearchHandler.java Transmitting file data ..... Committed revision 667923.

            People

            • Assignee:
              Otis Gospodnetic
              Reporter:
              Lars Kotthoff
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development