Solr
  1. Solr
  2. SOLR-591

Solrj default value for facet.sort is false

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.3
    • Fix Version/s: 1.3
    • Component/s: clients - java
    • Labels:
      None

      Description

      The default value for facet.sort in SolrQuery is false despite the javadoc saying it's true.

        Activity

        Hide
        Lars Kotthoff added a comment -

        Patch adjusting the default value to true and adding a test case which verifies that behaviour.

        I suppose it's debatable whether the default value should be true (as the javadoc says) or false (as the implementation defined it). Setting it to true makes the behaviour more consistent with the HTTP interface behaviour though.

        Show
        Lars Kotthoff added a comment - Patch adjusting the default value to true and adding a test case which verifies that behaviour. I suppose it's debatable whether the default value should be true (as the javadoc says) or false (as the implementation defined it). Setting it to true makes the behaviour more consistent with the HTTP interface behaviour though.
        Hide
        Lars Kotthoff added a comment -

        Syncing patch with trunk.

        Show
        Lars Kotthoff added a comment - Syncing patch with trunk.
        Hide
        Shalin Shekhar Mangar added a comment -

        Committed Revision 682587.

        Thanks Lars!

        Show
        Shalin Shekhar Mangar added a comment - Committed Revision 682587. Thanks Lars!

          People

          • Assignee:
            Shalin Shekhar Mangar
            Reporter:
            Lars Kotthoff
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development