Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-591

Solrj default value for facet.sort is false

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.3
    • Fix Version/s: 1.3
    • Component/s: clients - java
    • Labels:
      None

      Description

      The default value for facet.sort in SolrQuery is false despite the javadoc saying it's true.

        Activity

        Hide
        larsko Lars Kotthoff added a comment -

        Patch adjusting the default value to true and adding a test case which verifies that behaviour.

        I suppose it's debatable whether the default value should be true (as the javadoc says) or false (as the implementation defined it). Setting it to true makes the behaviour more consistent with the HTTP interface behaviour though.

        Show
        larsko Lars Kotthoff added a comment - Patch adjusting the default value to true and adding a test case which verifies that behaviour. I suppose it's debatable whether the default value should be true (as the javadoc says) or false (as the implementation defined it). Setting it to true makes the behaviour more consistent with the HTTP interface behaviour though.
        Hide
        larsko Lars Kotthoff added a comment -

        Syncing patch with trunk.

        Show
        larsko Lars Kotthoff added a comment - Syncing patch with trunk.
        Hide
        shalinmangar Shalin Shekhar Mangar added a comment -

        Committed Revision 682587.

        Thanks Lars!

        Show
        shalinmangar Shalin Shekhar Mangar added a comment - Committed Revision 682587. Thanks Lars!

          People

          • Assignee:
            shalinmangar Shalin Shekhar Mangar
            Reporter:
            larsko Lars Kotthoff
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development