Solr
  1. Solr
  2. SOLR-5884

When recovery is cancelled, any call to the leader to wait to see the replica in the right state for recovery should be aborted.

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.8, 6.0
    • Component/s: SolrCloud
    • Labels:
      None

      Description

      Noticed this as "UnloadDistributedZkTest is slower than it should be". This test ends up waiting a long time to cancel a recovery because the prep recovery command is stuck while the remote node waits to timeout seeing a state it will never see.

        Activity

        Hide
        Mark Miller added a comment -

        Rough patch - adds the ability to cancel an HttpSolrServer request that is in progress and cancels the wait for state call made in RecoveryStrategy on close.

        Show
        Mark Miller added a comment - Rough patch - adds the ability to cancel an HttpSolrServer request that is in progress and cancels the wait for state call made in RecoveryStrategy on close.
        Hide
        Mark Miller added a comment -

        For me that brings the test down from 70-80 seconds to 40-50 seconds. I'll clean it up for commit.

        Show
        Mark Miller added a comment - For me that brings the test down from 70-80 seconds to 40-50 seconds. I'll clean it up for commit.
        Hide
        ASF subversion and git services added a comment -

        Commit 1580714 from Mark Miller in branch 'dev/trunk'
        [ https://svn.apache.org/r1580714 ]

        SOLR-5884: When recovery is cancelled, any call to the leader to wait to see the replica in the right state for recovery should be aborted.

        Show
        ASF subversion and git services added a comment - Commit 1580714 from Mark Miller in branch 'dev/trunk' [ https://svn.apache.org/r1580714 ] SOLR-5884 : When recovery is cancelled, any call to the leader to wait to see the replica in the right state for recovery should be aborted.
        Hide
        ASF subversion and git services added a comment -

        Commit 1580715 from Mark Miller in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1580715 ]

        SOLR-5884: When recovery is cancelled, any call to the leader to wait to see the replica in the right state for recovery should be aborted.

        Show
        ASF subversion and git services added a comment - Commit 1580715 from Mark Miller in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1580715 ] SOLR-5884 : When recovery is cancelled, any call to the leader to wait to see the replica in the right state for recovery should be aborted.
        Hide
        ASF subversion and git services added a comment -

        Commit 1580739 from Mark Miller in branch 'dev/trunk'
        [ https://svn.apache.org/r1580739 ]

        SOLR-5884: Name executor threads and use execturo shutdown rather than shutdownNow.

        Show
        ASF subversion and git services added a comment - Commit 1580739 from Mark Miller in branch 'dev/trunk' [ https://svn.apache.org/r1580739 ] SOLR-5884 : Name executor threads and use execturo shutdown rather than shutdownNow.
        Hide
        ASF subversion and git services added a comment -

        Commit 1580740 from Mark Miller in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1580740 ]

        SOLR-5884: Name executor threads and use execturo shutdown rather than shutdownNow.

        Show
        ASF subversion and git services added a comment - Commit 1580740 from Mark Miller in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1580740 ] SOLR-5884 : Name executor threads and use execturo shutdown rather than shutdownNow.
        Hide
        Uwe Schindler added a comment -

        Move issue to Solr 4.9.

        Show
        Uwe Schindler added a comment - Move issue to Solr 4.9.

          People

          • Assignee:
            Mark Miller
            Reporter:
            Mark Miller
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development