[SOLR-5883] Shutdown SolrServer on tests

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 4.7, 6.0
• Fix Version/s: 4.8, 6.0
• Assignee: Mark Miller
• Reporter: Tomas Eduardo Fernandez Lobbe
• Created: 19/Mar/14 17:53
• Updated: 09/May/16 18:45
• Resolved: 19/Mar/14 18:27

Description

I noticed that many tests create multiple HttpSolrServer but never call the shutdown. I created a Jira for BasicDistributedZk2Test and BasicDistributedZkTest some time ago but didn’t check for all tests (SOLR-5684). I added the missing shutdowns that I found in other tests now.
I’m also wondering if it makes sense to add some kind of check in the tests, in a similar way that open/close of IndexSearchers is checked (probably, not blocking or falling the test if open/close doesn’t much, but maybe to output a warning to the logs?)