Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 4.7, 6.0
    • Fix Version/s: 4.8, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      I noticed that many tests create multiple HttpSolrServer but never call the shutdown. I created a Jira for BasicDistributedZk2Test and BasicDistributedZkTest some time ago but didn’t check for all tests (SOLR-5684). I added the missing shutdowns that I found in other tests now.
      I’m also wondering if it makes sense to add some kind of check in the tests, in a similar way that open/close of IndexSearchers is checked (probably, not blocking or falling the test if open/close doesn’t much, but maybe to output a warning to the logs?)

      1. SOLR-5883.patch
        44 kB
        Tomás Fernández Löbbe

        Activity

        Hide
        ASF subversion and git services added a comment -

        Commit 1579336 from Mark Miller in branch 'dev/trunk'
        [ https://svn.apache.org/r1579336 ]

        SOLR-5883: Many tests do not shutdown SolrServer.

        Show
        ASF subversion and git services added a comment - Commit 1579336 from Mark Miller in branch 'dev/trunk' [ https://svn.apache.org/r1579336 ] SOLR-5883 : Many tests do not shutdown SolrServer.
        Hide
        ASF subversion and git services added a comment -

        Commit 1579338 from Mark Miller in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1579338 ]

        SOLR-5883: Many tests do not shutdown SolrServer.

        Show
        ASF subversion and git services added a comment - Commit 1579338 from Mark Miller in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1579338 ] SOLR-5883 : Many tests do not shutdown SolrServer.
        Hide
        Mark Miller added a comment -

        Thanks Tomás!

        Show
        Mark Miller added a comment - Thanks Tomás!
        Hide
        Uwe Schindler added a comment -

        Close issue after release of 4.8.0

        Show
        Uwe Schindler added a comment - Close issue after release of 4.8.0

          People

          • Assignee:
            Mark Miller
            Reporter:
            Tomás Fernández Löbbe
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development