Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-5864

Remove previous SolrCore as parameter on reload

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 6.0
    • Fix Version/s: 5.0, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      Currently the reload method is reload(SolrResourceLoader resourceLoader, SolrCore prev), but all the times it’s called with “prev” being the same as “this”:
      core.reload(resourceLoader, core).
      Frankly, I don’t think it even makes sense to call it in other way (it would be just to create the first reader with a different core than the one its being reloaded?)
      I think we should just remove the SolrCore parameter and let the "reload" method always reload the core where it's being called.

        Attachments

        1. SOLR-5864.patch
          2 kB
          Tomás Fernández Löbbe
        2. SOLR-5864.patch
          4 kB
          Tomás Fernández Löbbe
        3. SOLR-5864.patch
          2 kB
          Tomás Fernández Löbbe
        4. SOLR-5864.patch
          2 kB
          Tomás Fernández Löbbe

          Activity

            People

            • Assignee:
              tomasflobbe Tomás Fernández Löbbe
              Reporter:
              tomasflobbe Tomás Fernández Löbbe
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: