Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-5864

Remove previous SolrCore as parameter on reload

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Trivial
    • Resolution: Fixed
    • 6.0
    • 5.0, 6.0
    • None
    • None

    Description

      Currently the reload method is reload(SolrResourceLoader resourceLoader, SolrCore prev), but all the times it’s called with “prev” being the same as “this”:
      core.reload(resourceLoader, core).
      Frankly, I don’t think it even makes sense to call it in other way (it would be just to create the first reader with a different core than the one its being reloaded?)
      I think we should just remove the SolrCore parameter and let the "reload" method always reload the core where it's being called.

      Attachments

        1. SOLR-5864.patch
          2 kB
          Tomas Eduardo Fernandez Lobbe
        2. SOLR-5864.patch
          2 kB
          Tomas Eduardo Fernandez Lobbe
        3. SOLR-5864.patch
          4 kB
          Tomas Eduardo Fernandez Lobbe
        4. SOLR-5864.patch
          2 kB
          Tomas Eduardo Fernandez Lobbe

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            tflobbe Tomas Eduardo Fernandez Lobbe
            tflobbe Tomas Eduardo Fernandez Lobbe
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment