Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-5863

Asserts wrong way around in TestSolrXml

        Details

        • Type: Test
        • Status: Closed
        • Priority: Major
        • Resolution: Fixed
        • Affects Version/s: 4.7
        • Fix Version/s: 4.8, 6.0
        • Component/s: Tests
        • Labels:
          None

          Description

          the assertEquals tests in this class have switched the "expected" and "actual" arguments which may be confusing if the assert fails.

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            jira-bot ASF subversion and git services added a comment -

            Commit 1577539 from janhoy@apache.org in branch 'dev/trunk'
            [ https://svn.apache.org/r1577539 ]

            SOLR-5863: Asserts wrong way around in TestSolrXml and a few other classes

            Show
            jira-bot ASF subversion and git services added a comment - Commit 1577539 from janhoy@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1577539 ] SOLR-5863 : Asserts wrong way around in TestSolrXml and a few other classes
            Hide
            Permalink
            jira-bot ASF subversion and git services added a comment -

            Commit 1577542 from janhoy@apache.org in branch 'dev/branches/branch_4x'
            [ https://svn.apache.org/r1577542 ]

            SOLR-5863: Asserts wrong way around in TestSolrXml and a few other classes (merge from trunk)

            Show
            jira-bot ASF subversion and git services added a comment - Commit 1577542 from janhoy@apache.org in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1577542 ] SOLR-5863 : Asserts wrong way around in TestSolrXml and a few other classes (merge from trunk)
            Hide
            Permalink
            janhoy Jan Høydahl added a comment -

            For information: I did not find this small patch in test-land worthy of a CHANGES entry.

            Show
            janhoy Jan Høydahl added a comment - For information: I did not find this small patch in test-land worthy of a CHANGES entry.
            Hide
            Permalink
            thetaphi Uwe Schindler added a comment -

            Close issue after release of 4.8.0

            Show
            thetaphi Uwe Schindler added a comment - Close issue after release of 4.8.0

              People

              • Assignee:
                janhoy Jan Høydahl
                Reporter:
                janhoy Jan Høydahl
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development