Solr
  1. Solr
  2. SOLR-5853

Return status for AbstractFullDistribZkTestBase#createCollection() and friends

    Details

    • Type: Test Test
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.8, 6.0
    • Component/s: Tests
    • Labels:
      None

      Description

      Spinoff from SOLR-4470

      Should use the excellent progress from SOLR-4577 and have the createCollection methods in the test framework return a status (currently void). This way we can get rid of some unnecessary and unreliable sleep's.

      1. SOLR-5853.patch
        10 kB
        Jan Høydahl

        Issue Links

          Activity

          Hide
          Alan Woodward added a comment -

          As an alternative, maybe we should nuke #createCollection() and friends, and use the SolrJ APIs instead? And if those APIs aren't up to scratch, improve them till they are? Would be a good way of eating our own dogfood, plus it ensures that we're testing what users will actually use.

          Show
          Alan Woodward added a comment - As an alternative, maybe we should nuke #createCollection() and friends, and use the SolrJ APIs instead? And if those APIs aren't up to scratch, improve them till they are? Would be a good way of eating our own dogfood, plus it ensures that we're testing what users will actually use.
          Hide
          Jan Høydahl added a comment -

          Yep, that's what I plan on doing, using the new CollectionAdminRequest SolrJ API.

          Show
          Jan Høydahl added a comment - Yep, that's what I plan on doing, using the new CollectionAdminRequest SolrJ API.
          Hide
          Jan Høydahl added a comment -

          First patch adding the return values along with one new assert utilizing it. Also renamed variable numReplicas -> replicationFactor.

          This version is a least intrusion version without cutting everything over to CollectionAdminRequest - that can be done in another issue.

          Show
          Jan Høydahl added a comment - First patch adding the return values along with one new assert utilizing it. Also renamed variable numReplicas -> replicationFactor. This version is a least intrusion version without cutting everything over to CollectionAdminRequest - that can be done in another issue.
          Hide
          Jan Høydahl added a comment -

          All tests and precommit pass. Will commit this soon

          Show
          Jan Høydahl added a comment - All tests and precommit pass. Will commit this soon
          Hide
          Alan Woodward added a comment -

          +1

          Show
          Alan Woodward added a comment - +1
          Hide
          ASF subversion and git services added a comment -

          Commit 1577156 from janhoy@apache.org in branch 'dev/trunk'
          [ https://svn.apache.org/r1577156 ]

          SOLR-5853: Return status for AbstractFullDistribZkTestBase#createCollection() and friends

          Show
          ASF subversion and git services added a comment - Commit 1577156 from janhoy@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1577156 ] SOLR-5853 : Return status for AbstractFullDistribZkTestBase#createCollection() and friends
          Hide
          ASF subversion and git services added a comment -

          Commit 1577166 from janhoy@apache.org in branch 'dev/branches/branch_4x'
          [ https://svn.apache.org/r1577166 ]

          SOLR-5853: Return status for AbstractFullDistribZkTestBase#createCollection() and friends (backport)

          Show
          ASF subversion and git services added a comment - Commit 1577166 from janhoy@apache.org in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1577166 ] SOLR-5853 : Return status for AbstractFullDistribZkTestBase#createCollection() and friends (backport)
          Hide
          Uwe Schindler added a comment -

          Close issue after release of 4.8.0

          Show
          Uwe Schindler added a comment - Close issue after release of 4.8.0

            People

            • Assignee:
              Jan Høydahl
              Reporter:
              Jan Høydahl
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development