Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.1, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      I have added docValues functionality to EnumField.
      Please review the patch attached.
      If there is any problem with it, please let me know.

      1. Solr-5846.patch
        4 kB
        Elran Dvir
      2. Solr-5846.patch
        3 kB
        Elran Dvir
      3. SOLR-5846.patch
        7 kB
        Shalin Shekhar Mangar
      4. SOLR-5846.patch
        2 kB
        Elran Dvir

        Activity

        Hide
        Elran Dvir added a comment -

        Hi all,
        Did anyone have a chance to take a look at my code?
        Attached new patch with removal of checkSchemaField logic because since version 4.5 single-valued docvalues fields no longer require 'default' or 'required'.
        The patch is based on Solr 4.9

        Thanks.

        Show
        Elran Dvir added a comment - Hi all, Did anyone have a chance to take a look at my code? Attached new patch with removal of checkSchemaField logic because since version 4.5 single-valued docvalues fields no longer require 'default' or 'required'. The patch is based on Solr 4.9 Thanks.
        Hide
        Shalin Shekhar Mangar added a comment -

        Can you please add a test?

        Show
        Shalin Shekhar Mangar added a comment - Can you please add a test?
        Hide
        Elran Dvir added a comment -

        Thank you very much for your attention.

        Attaching new patch with test.
        I only added docValues="true" in schema and rerun existing EnumFieldTest. All tests passed.
        Is it sufficient?

        Thanks.

        Show
        Elran Dvir added a comment - Thank you very much for your attention. Attaching new patch with test. I only added docValues="true" in schema and rerun existing EnumFieldTest. All tests passed. Is it sufficient? Thanks.
        Hide
        Shalin Shekhar Mangar added a comment -

        Thanks Elran.

        This patch is in sync with trunk. Your change to the schema had removed test coverage for non-DocValue enum fields so I added a new field called severity_dv and I switch between the DocValue and non-DocValue field randomly in the test.

        I'll commit this shortly.

        Show
        Shalin Shekhar Mangar added a comment - Thanks Elran. This patch is in sync with trunk. Your change to the schema had removed test coverage for non-DocValue enum fields so I added a new field called severity_dv and I switch between the DocValue and non-DocValue field randomly in the test. I'll commit this shortly.
        Hide
        ASF subversion and git services added a comment -

        Commit 1665107 from shalin@apache.org in branch 'dev/trunk'
        [ https://svn.apache.org/r1665107 ]

        SOLR-5846: EnumField supports DocValues functionality

        Show
        ASF subversion and git services added a comment - Commit 1665107 from shalin@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1665107 ] SOLR-5846 : EnumField supports DocValues functionality
        Hide
        Shalin Shekhar Mangar added a comment -

        Thanks Elran!

        Show
        Shalin Shekhar Mangar added a comment - Thanks Elran!
        Hide
        ASF subversion and git services added a comment -

        Commit 1665108 from shalin@apache.org in branch 'dev/branches/branch_5x'
        [ https://svn.apache.org/r1665108 ]

        SOLR-5846: EnumField supports DocValues functionality

        Show
        ASF subversion and git services added a comment - Commit 1665108 from shalin@apache.org in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1665108 ] SOLR-5846 : EnumField supports DocValues functionality
        Hide
        Timothy Potter added a comment -

        Bulk close after 5.1 release

        Show
        Timothy Potter added a comment - Bulk close after 5.1 release

          People

          • Assignee:
            Shalin Shekhar Mangar
            Reporter:
            Elran Dvir
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development