Solr
  1. Solr
  2. SOLR-5839

ZookeeperInfoServlet Does Not Trim Path Properly

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 4.6.1, 4.7
    • Fix Version/s: 4.7.1, 4.8, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      This part has a bug:

      // normalize path
            if (path == null) {
              path = "/";
            } else {
              path.trim();
              if (path.length() == 0) {
                path = "/";
              }
            }
      
      1. SOLR-5839.patch
        0.6 kB
        Furkan KAMACI

        Activity

        Hide
        Furkan KAMACI added a comment -

        I've attached the patch file.

        Show
        Furkan KAMACI added a comment - I've attached the patch file.
        Hide
        Mark Miller added a comment -

        Thanks Furkan!

        We should leave the JIRA issue unresolved until a committer actually commits it though.

        Show
        Mark Miller added a comment - Thanks Furkan! We should leave the JIRA issue unresolved until a committer actually commits it though.
        Hide
        ASF subversion and git services added a comment -

        Commit 1575592 from Mark Miller in branch 'dev/trunk'
        [ https://svn.apache.org/r1575592 ]

        SOLR-5839: ZookeeperInfoServlet does not trim path properly.

        Show
        ASF subversion and git services added a comment - Commit 1575592 from Mark Miller in branch 'dev/trunk' [ https://svn.apache.org/r1575592 ] SOLR-5839 : ZookeeperInfoServlet does not trim path properly.
        Hide
        ASF subversion and git services added a comment -

        Commit 1575593 from Mark Miller in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1575593 ]

        SOLR-5839: ZookeeperInfoServlet does not trim path properly.

        Show
        ASF subversion and git services added a comment - Commit 1575593 from Mark Miller in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1575593 ] SOLR-5839 : ZookeeperInfoServlet does not trim path properly.
        Hide
        Steve Rowe added a comment -

        Mark Miller, any reason not to backport this to 4.7.1?

        Show
        Steve Rowe added a comment - Mark Miller , any reason not to backport this to 4.7.1?
        Hide
        ASF subversion and git services added a comment -

        Commit 1581214 from Steve Rowe in branch 'dev/branches/lucene_solr_4_7'
        [ https://svn.apache.org/r1581214 ]

        SOLR-5839: ZookeeperInfoServlet does not trim path properly. (merged branch_4x r1575593)

        Show
        ASF subversion and git services added a comment - Commit 1581214 from Steve Rowe in branch 'dev/branches/lucene_solr_4_7' [ https://svn.apache.org/r1581214 ] SOLR-5839 : ZookeeperInfoServlet does not trim path properly. (merged branch_4x r1575593)
        Hide
        ASF subversion and git services added a comment -

        Commit 1581215 from Steve Rowe in branch 'dev/trunk'
        [ https://svn.apache.org/r1581215 ]

        SOLR-5839: move CHANGES.txt entry to 4.7.1 section

        Show
        ASF subversion and git services added a comment - Commit 1581215 from Steve Rowe in branch 'dev/trunk' [ https://svn.apache.org/r1581215 ] SOLR-5839 : move CHANGES.txt entry to 4.7.1 section
        Hide
        ASF subversion and git services added a comment -

        Commit 1581216 from Steve Rowe in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1581216 ]

        SOLR-5839: move CHANGES.txt entry to 4.7.1 section (merged trunk r1581215)

        Show
        ASF subversion and git services added a comment - Commit 1581216 from Steve Rowe in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1581216 ] SOLR-5839 : move CHANGES.txt entry to 4.7.1 section (merged trunk r1581215)
        Hide
        Steve Rowe added a comment -

        Bulk close 4.7.1 issues

        Show
        Steve Rowe added a comment - Bulk close 4.7.1 issues

          People

          • Assignee:
            Mark Miller
            Reporter:
            Furkan KAMACI
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development