Solr
  1. Solr
  2. SOLR-5818

distrib search with custom comparator does not quite work correctly

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.7.1, 4.8, Trunk
    • Component/s: None
    • Labels:
      None

      Description

      In QueryComponent.doFieldSortValues, a scorer is never set on a custom comparator. We just need to add a fake scorer that can pass through the score from the DocList.

        Activity

        Ryan Ernst created issue -
        Hide
        Ryan Ernst added a comment -

        Patch with test.

        Show
        Ryan Ernst added a comment - Patch with test.
        Ryan Ernst made changes -
        Field Original Value New Value
        Attachment SOLR-5818.patch [ 12632872 ]
        Hide
        Mark Miller added a comment -

        +1 - LGTM.

        Show
        Mark Miller added a comment - +1 - LGTM.
        Hide
        ASF subversion and git services added a comment -

        Commit 1575344 from Ryan Ernst in branch 'dev/trunk'
        [ https://svn.apache.org/r1575344 ]

        SOLR-5818: distrib search with custom comparator does not quite work correctly

        Show
        ASF subversion and git services added a comment - Commit 1575344 from Ryan Ernst in branch 'dev/trunk' [ https://svn.apache.org/r1575344 ] SOLR-5818 : distrib search with custom comparator does not quite work correctly
        Ryan Ernst made changes -
        Assignee Ryan Ernst [ rjernst ]
        Ryan Ernst made changes -
        Fix Version/s 4.8 [ 12326254 ]
        Fix Version/s 5.0 [ 12321664 ]
        Hide
        ASF subversion and git services added a comment -

        Commit 1575370 from Ryan Ernst in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1575370 ]

        SOLR-5818: distrib search with custom comparator does not quite work correctly

        Show
        ASF subversion and git services added a comment - Commit 1575370 from Ryan Ernst in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1575370 ] SOLR-5818 : distrib search with custom comparator does not quite work correctly
        Ryan Ernst made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        ASF subversion and git services added a comment -

        Commit 1575446 from hossman@apache.org in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1575446 ]

        SOLR-5818: Fix java1.6 source compatibility

        Show
        ASF subversion and git services added a comment - Commit 1575446 from hossman@apache.org in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1575446 ] SOLR-5818 : Fix java1.6 source compatibility
        Hide
        ASF subversion and git services added a comment -

        Commit 1575519 from Uwe Schindler in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1575519 ]

        SOLR-5818: Prevent overflow in Hoss' fix for Java 1.6 source compatibility

        Show
        ASF subversion and git services added a comment - Commit 1575519 from Uwe Schindler in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1575519 ] SOLR-5818 : Prevent overflow in Hoss' fix for Java 1.6 source compatibility
        Hide
        ASF subversion and git services added a comment -

        Commit 1576344 from shalin@apache.org in branch 'dev/trunk'
        [ https://svn.apache.org/r1576344 ]

        SOLR-5818: Add lucene expressions as a dependency on solr-core-tests idea file

        Show
        ASF subversion and git services added a comment - Commit 1576344 from shalin@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1576344 ] SOLR-5818 : Add lucene expressions as a dependency on solr-core-tests idea file
        Hide
        ASF subversion and git services added a comment -

        Commit 1576346 from shalin@apache.org in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1576346 ]

        SOLR-5818: Add lucene expressions as a dependency on solr-core-tests idea file

        Show
        ASF subversion and git services added a comment - Commit 1576346 from shalin@apache.org in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1576346 ] SOLR-5818 : Add lucene expressions as a dependency on solr-core-tests idea file
        Hide
        Steve Rowe added a comment -

        Ryan Ernst, any reason not to backport this to 4.7.1?

        Show
        Steve Rowe added a comment - Ryan Ernst , any reason not to backport this to 4.7.1?
        Hide
        Ryan Ernst added a comment -

        Nope, I will do that now.

        Show
        Ryan Ernst added a comment - Nope, I will do that now.
        Hide
        ASF subversion and git services added a comment -

        Commit 1580987 from Ryan Ernst in branch 'dev/branches/lucene_solr_4_7'
        [ https://svn.apache.org/r1580987 ]

        SOLR-5818: distrib search with custom comparator does not quite work correctly

        Show
        ASF subversion and git services added a comment - Commit 1580987 from Ryan Ernst in branch 'dev/branches/lucene_solr_4_7' [ https://svn.apache.org/r1580987 ] SOLR-5818 : distrib search with custom comparator does not quite work correctly
        Ryan Ernst made changes -
        Fix Version/s 4.7.1 [ 12326521 ]
        Hide
        ASF subversion and git services added a comment -

        Commit 1581239 from Steve Rowe in branch 'dev/trunk'
        [ https://svn.apache.org/r1581239 ]

        SOLR-5818: move CHANGES.txt entry to 4.7.1 section

        Show
        ASF subversion and git services added a comment - Commit 1581239 from Steve Rowe in branch 'dev/trunk' [ https://svn.apache.org/r1581239 ] SOLR-5818 : move CHANGES.txt entry to 4.7.1 section
        Hide
        ASF subversion and git services added a comment -

        Commit 1581240 from Steve Rowe in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1581240 ]

        SOLR-5818: move CHANGES.txt entry to 4.7.1 section (merged trunk r1581239)

        Show
        ASF subversion and git services added a comment - Commit 1581240 from Steve Rowe in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1581240 ] SOLR-5818 : move CHANGES.txt entry to 4.7.1 section (merged trunk r1581239)
        Hide
        Steve Rowe added a comment -

        Bulk close 4.7.1 issues

        Show
        Steve Rowe added a comment - Bulk close 4.7.1 issues
        Steve Rowe made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        2d 24m 1 Ryan Ernst 07/Mar/14 18:55
        Resolved Resolved Closed Closed
        25d 20h 7m 1 Steve Rowe 02/Apr/14 16:03

          People

          • Assignee:
            Ryan Ernst
            Reporter:
            Ryan Ernst
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development