Solr
  1. Solr
  2. SOLR-5770

All attempts to match a SolrCore with it's state in clusterstate.json should be done with the NodeName rather than the baseUrl.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.7.1, 4.8, 6.0
    • Component/s: SolrCloud
    • Labels:
      None
    1. SOLR-5770.patch
      11 kB
      Steve Davids
    2. SOLR-5770.patch
      9 kB
      Steve Davids

      Issue Links

        Activity

        Hide
        Mark Miller added a comment -

        As noticed and patched by Steve Davids in SOLR-3854.

        Show
        Mark Miller added a comment - As noticed and patched by Steve Davids in SOLR-3854 .
        Hide
        Mark Miller added a comment -

        I'll put this in as if it's going out in 4.7, but that doesn't seem likely and I will adjust before resolving once 4.7 is released.

        Show
        Mark Miller added a comment - I'll put this in as if it's going out in 4.7, but that doesn't seem likely and I will adjust before resolving once 4.7 is released.
        Hide
        ASF subversion and git services added a comment -

        Commit 1571349 from Mark Miller in branch 'dev/trunk'
        [ https://svn.apache.org/r1571349 ]

        SOLR-5770: All attempts to match a SolrCore with it's state in clusterstate.json should be done with the CoreNodeName.

        Show
        ASF subversion and git services added a comment - Commit 1571349 from Mark Miller in branch 'dev/trunk' [ https://svn.apache.org/r1571349 ] SOLR-5770 : All attempts to match a SolrCore with it's state in clusterstate.json should be done with the CoreNodeName.
        Hide
        ASF subversion and git services added a comment -

        Commit 1571352 from Mark Miller in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1571352 ]

        SOLR-5770: All attempts to match a SolrCore with it's state in clusterstate.json should be done with the CoreNodeName.

        Show
        ASF subversion and git services added a comment - Commit 1571352 from Mark Miller in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1571352 ] SOLR-5770 : All attempts to match a SolrCore with it's state in clusterstate.json should be done with the CoreNodeName.
        Hide
        ASF subversion and git services added a comment -

        Commit 1571366 from Mark Miller in branch 'dev/branches/lucene_solr_4_7'
        [ https://svn.apache.org/r1571366 ]

        SOLR-5770: All attempts to match a SolrCore with it's state in clusterstate.json should be done with the CoreNodeName.

        Show
        ASF subversion and git services added a comment - Commit 1571366 from Mark Miller in branch 'dev/branches/lucene_solr_4_7' [ https://svn.apache.org/r1571366 ] SOLR-5770 : All attempts to match a SolrCore with it's state in clusterstate.json should be done with the CoreNodeName.
        Hide
        Steve Davids added a comment - - edited

        Attached a new patch, found a couple more places where the base_url was being used – we should probably find a common place to put this base logic. Also, added a SSL migration test from http to https then back to http. This test did not pass without the additional modifications made in the patch.

        I wasn't having luck running shard splitting tests on my local machine, nor with a clean checkout of the solr_4x branch - if someone could run a sanity check before checking it in that would be great.

        Show
        Steve Davids added a comment - - edited Attached a new patch, found a couple more places where the base_url was being used – we should probably find a common place to put this base logic. Also, added a SSL migration test from http to https then back to http. This test did not pass without the additional modifications made in the patch. I wasn't having luck running shard splitting tests on my local machine, nor with a clean checkout of the solr_4x branch - if someone could run a sanity check before checking it in that would be great.
        Hide
        Steve Davids added a comment -

        Just noticing the title of this ticket, these patches are matching on the replica's node_name, not the core_node_name.

        Show
        Steve Davids added a comment - Just noticing the title of this ticket, these patches are matching on the replica's node_name, not the core_node_name.
        Hide
        Mark Miller added a comment -

        Thanks Steve - I'll look closer at this soon.

        Show
        Mark Miller added a comment - Thanks Steve - I'll look closer at this soon.
        Hide
        Mark Miller added a comment -

        I'm seeing some troubles with a test or two I think - I'll dig into this when I get a chance.

        Show
        Mark Miller added a comment - I'm seeing some troubles with a test or two I think - I'll dig into this when I get a chance.
        Hide
        Steve Davids added a comment -

        Uploaded a new patch, SolrCloud test suite is passing now.

        Show
        Steve Davids added a comment - Uploaded a new patch, SolrCloud test suite is passing now.
        Hide
        Mark Miller added a comment -

        Awesome, thanks Steve - had not had a chance to look further at this yet. I'll try your patch this weekend.

        Show
        Mark Miller added a comment - Awesome, thanks Steve - had not had a chance to look further at this yet. I'll try your patch this weekend.
        Hide
        ASF subversion and git services added a comment -

        Commit 1578623 from Steve Rowe in branch 'dev/branches/lucene_solr_4_7'
        [ https://svn.apache.org/r1578623 ]

        SOLR-5647,SOLR-5770 entries -> 4.7.1 release section

        Show
        ASF subversion and git services added a comment - Commit 1578623 from Steve Rowe in branch 'dev/branches/lucene_solr_4_7' [ https://svn.apache.org/r1578623 ] SOLR-5647 , SOLR-5770 entries -> 4.7.1 release section
        Hide
        Steve Rowe added a comment -

        Now that there will be a 4.7.1 release, should Steve Davids's latest patch get committed? Looks like it never made it to trunk/branch_4x?

        Show
        Steve Rowe added a comment - Now that there will be a 4.7.1 release, should Steve Davids 's latest patch get committed? Looks like it never made it to trunk/branch_4x?
        Hide
        Mark Miller added a comment -

        Already running the tests.

        Show
        Mark Miller added a comment - Already running the tests.
        Hide
        ASF subversion and git services added a comment -

        Commit 1578635 from Mark Miller in branch 'dev/trunk'
        [ https://svn.apache.org/r1578635 ]

        SOLR-5770: Further fixes and SSL migration test.

        Show
        ASF subversion and git services added a comment - Commit 1578635 from Mark Miller in branch 'dev/trunk' [ https://svn.apache.org/r1578635 ] SOLR-5770 : Further fixes and SSL migration test.
        Hide
        Steve Davids added a comment -

        I also came across a few other small issues dealing with SSL support documented here: http://markmail.org/message/rds3gbatnnlcxim3 would be great if we could get SOLR-5866, SOLR-5867, and SOLR-5868 added into 4.7.1 as well.

        Show
        Steve Davids added a comment - I also came across a few other small issues dealing with SSL support documented here: http://markmail.org/message/rds3gbatnnlcxim3 would be great if we could get SOLR-5866 , SOLR-5867 , and SOLR-5868 added into 4.7.1 as well.
        Hide
        ASF subversion and git services added a comment -

        Commit 1578651 from Mark Miller in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1578651 ]

        SOLR-5770: Further fixes and SSL migration test.

        Show
        ASF subversion and git services added a comment - Commit 1578651 from Mark Miller in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1578651 ] SOLR-5770 : Further fixes and SSL migration test.
        Hide
        ASF subversion and git services added a comment -

        Commit 1578654 from Mark Miller in branch 'dev/branches/lucene_solr_4_7'
        [ https://svn.apache.org/r1578654 ]

        SOLR-5770: Further fixes and SSL migration test.

        Show
        ASF subversion and git services added a comment - Commit 1578654 from Mark Miller in branch 'dev/branches/lucene_solr_4_7' [ https://svn.apache.org/r1578654 ] SOLR-5770 : Further fixes and SSL migration test.
        Hide
        Steve Rowe added a comment -

        Bulk close 4.7.1 issues

        Show
        Steve Rowe added a comment - Bulk close 4.7.1 issues

          People

          • Assignee:
            Mark Miller
            Reporter:
            Mark Miller
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development