Solr
  1. Solr
  2. SOLR-5731

In ConnectionManager, we should catch and only log exceptions from BeforeReconnect.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.7, Trunk
    • Component/s: None
    • Labels:
      None

      Activity

      Hide
      Mark Miller added a comment -

      With our internal use, this wasn't really an issue yet - the only current impl had a try / catch / exception around it.

      Show
      Mark Miller added a comment - With our internal use, this wasn't really an issue yet - the only current impl had a try / catch / exception around it.
      Hide
      ASF subversion and git services added a comment -

      Commit 1568353 from Mark Miller in branch 'dev/trunk'
      [ https://svn.apache.org/r1568353 ]

      SOLR-5731: In ConnectionManager, we should catch and only log exceptions from BeforeReconnect.

      Show
      ASF subversion and git services added a comment - Commit 1568353 from Mark Miller in branch 'dev/trunk' [ https://svn.apache.org/r1568353 ] SOLR-5731 : In ConnectionManager, we should catch and only log exceptions from BeforeReconnect.
      Hide
      ASF subversion and git services added a comment -

      Commit 1568354 from Mark Miller in branch 'dev/trunk'
      [ https://svn.apache.org/r1568354 ]

      SOLR-5731: The actual catch and loging.

      Show
      ASF subversion and git services added a comment - Commit 1568354 from Mark Miller in branch 'dev/trunk' [ https://svn.apache.org/r1568354 ] SOLR-5731 : The actual catch and loging.
      Hide
      ASF subversion and git services added a comment -

      Commit 1568355 from Mark Miller in branch 'dev/branches/branch_4x'
      [ https://svn.apache.org/r1568355 ]

      SOLR-5731: In ConnectionManager, we should catch and only log exceptions from BeforeReconnect.

      Show
      ASF subversion and git services added a comment - Commit 1568355 from Mark Miller in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1568355 ] SOLR-5731 : In ConnectionManager, we should catch and only log exceptions from BeforeReconnect.
      Hide
      Mark Miller added a comment -

      4x commit has both 5x commits. I also move the call to set local leader flags to off from afterReconnect to beforeReconnect. It should not matter, in both cases it's before the new elections begin, but I think it fits better in beforeReconnect.

      Show
      Mark Miller added a comment - 4x commit has both 5x commits. I also move the call to set local leader flags to off from afterReconnect to beforeReconnect. It should not matter, in both cases it's before the new elections begin, but I think it fits better in beforeReconnect.

        People

        • Assignee:
          Mark Miller
          Reporter:
          Mark Miller
        • Votes:
          0 Vote for this issue
          Watchers:
          2 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development