Solr
  1. Solr
  2. SOLR-5727

LBHttpSolrServer should only retry on Connection exceptions when sending updates.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.7, 6.0
    • Component/s: SolrCloud
    • Labels:
      None

      Description

      You don't know if the request was successful or not and so its better to error to the user than retry, especially because forwards to a shard leader can be retried internally.

        Issue Links

          Activity

          Hide
          Mark Miller added a comment -

          There seem to be some unrelated failures that make my patch for this hard to test, but once that gets worked out, I'll post a patch and commit. I want to get this into jenkins to see the affects on chaosmonkey tests.

          I think SOLR-5593 was hiding / protecting against some issues around this. It also fits with some fails even before that I was trying to figure out and seemed to make no sense unless the client was resending the same update even while we were internally retrying to send an update to a leader.

          Show
          Mark Miller added a comment - There seem to be some unrelated failures that make my patch for this hard to test, but once that gets worked out, I'll post a patch and commit. I want to get this into jenkins to see the affects on chaosmonkey tests. I think SOLR-5593 was hiding / protecting against some issues around this. It also fits with some fails even before that I was trying to figure out and seemed to make no sense unless the client was resending the same update even while we were internally retrying to send an update to a leader.
          Hide
          ASF subversion and git services added a comment -

          Commit 1568857 from Mark Miller in branch 'dev/trunk'
          [ https://svn.apache.org/r1568857 ]

          SOLR-5727: LBHttpSolrServer should only retry on Connection exceptions when sending updates. Affects CloudSolrServer.

          Show
          ASF subversion and git services added a comment - Commit 1568857 from Mark Miller in branch 'dev/trunk' [ https://svn.apache.org/r1568857 ] SOLR-5727 : LBHttpSolrServer should only retry on Connection exceptions when sending updates. Affects CloudSolrServer.
          Hide
          ASF subversion and git services added a comment -

          Commit 1568859 from Mark Miller in branch 'dev/branches/branch_4x'
          [ https://svn.apache.org/r1568859 ]

          SOLR-5727: LBHttpSolrServer should only retry on Connection exceptions when sending updates. Affects CloudSolrServer.

          Show
          ASF subversion and git services added a comment - Commit 1568859 from Mark Miller in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1568859 ] SOLR-5727 : LBHttpSolrServer should only retry on Connection exceptions when sending updates. Affects CloudSolrServer.
          Hide
          Mark Miller added a comment -

          This has worked out nicely so far. If someone wants to do a closer review of the code that would be great. Resolving for the moment unless someone speaks up.

          Show
          Mark Miller added a comment - This has worked out nicely so far. If someone wants to do a closer review of the code that would be great. Resolving for the moment unless someone speaks up.

            People

            • Assignee:
              Mark Miller
              Reporter:
              Mark Miller
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development