Solr
  1. Solr
  2. SOLR-5675

cloud-scripts/zkcli.bat: quote option -Dlog4j...

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 4.6
    • Fix Version/s: 4.7, 6.0
    • Component/s: scripts and tools
    • Labels:
      None
    • Environment:

      Windows 7 64 bit

      Description

      In Skript zkcli.bat this java command line is build:

      "%JVM%" -Dlog4j.configuration=file:%SDIR%\log4j.properties

      The command failes if %SDIR% contains spaces ("C:\Program Files\...").
      Quoting the hole option "-Dlog4j.configuration=file:%SDIR%\log4j.properties" solved the isssue.

      1. SOLR-5675.patch
        1 kB
        Stefan Matheis (steffkes)

        Activity

        Hide
        Stefan Matheis (steffkes) added a comment -

        Thanks for reporting this Günter!

        Just to make sure, i get it right .. you suggest quoting the whole thing, instead of the arguments value only? I'd expect something like

        -Dlog4j.configuration="file:%SDIR%\log4j.properties" instead
        "-Dlog4j.configuration=file:%SDIR%\log4j.properties"

        If you are sure, that quoting the whole argument does the trick .. we can go ahead with that

        Show
        Stefan Matheis (steffkes) added a comment - Thanks for reporting this Günter! Just to make sure, i get it right .. you suggest quoting the whole thing, instead of the arguments value only? I'd expect something like -Dlog4j.configuration="file:%SDIR%\log4j.properties" instead "-Dlog4j.configuration= file:%SDIR%\log4j.properties " If you are sure, that quoting the whole argument does the trick .. we can go ahead with that
        Hide
        Günther Ruck added a comment -

        Hallo Stefan,

        I've tried your suggestion and it works. It is sufficient to quote the value of the option -Dlog4j.configuration="file:%SDIR%\log4j.properties"

        Show
        Günther Ruck added a comment - Hallo Stefan, I've tried your suggestion and it works. It is sufficient to quote the value of the option -Dlog4j.configuration="file:%SDIR%\log4j.properties"
        Hide
        ASF subversion and git services added a comment -

        Commit 1567901 from Stefan Matheis (steffkes) in branch 'dev/trunk'
        [ https://svn.apache.org/r1567901 ]

        SOLR-5675: cloud-scripts/zkcli.bat: quote option log4j

        Show
        ASF subversion and git services added a comment - Commit 1567901 from Stefan Matheis (steffkes) in branch 'dev/trunk' [ https://svn.apache.org/r1567901 ] SOLR-5675 : cloud-scripts/zkcli.bat: quote option log4j
        Hide
        ASF subversion and git services added a comment -

        Commit 1567902 from Stefan Matheis (steffkes) in branch 'dev/trunk'
        [ https://svn.apache.org/r1567902 ]

        SOLR-5675: cloud-scripts/zkcli.bat: quote option log4j

        Show
        ASF subversion and git services added a comment - Commit 1567902 from Stefan Matheis (steffkes) in branch 'dev/trunk' [ https://svn.apache.org/r1567902 ] SOLR-5675 : cloud-scripts/zkcli.bat: quote option log4j
        Hide
        ASF subversion and git services added a comment -

        Commit 1567904 from Stefan Matheis (steffkes) in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1567904 ]

        SOLR-5675: cloud-scripts/zkcli.bat: quote option log4j (merge r1567901, r1567902)

        Show
        ASF subversion and git services added a comment - Commit 1567904 from Stefan Matheis (steffkes) in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1567904 ] SOLR-5675 : cloud-scripts/zkcli.bat: quote option log4j (merge r1567901, r1567902)

          People

          • Assignee:
            Stefan Matheis (steffkes)
            Reporter:
            Günther Ruck
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development