Solr
  1. Solr
  2. SOLR-5636

SolrRequestParsers does some xpath lookups on every request.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.6.1, 4.7, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      This seems a bit wasteful for one, but also, under heavy load, with lots of cores on a node, I've seen this xpath parsing randomly fail with weird nullpointer exceptions. Perhaps depends on the xml parser you end up using. Anyway, it's easy to work around and avoid the parsing everytime solrdispatchfilter is hit by just doing it up front once.

        Activity

        Hide
        Yonik Seeley added a comment -

        Boy, that's definitely unexpected...
        +1, commit it!

        Show
        Yonik Seeley added a comment - Boy, that's definitely unexpected... +1, commit it!
        Hide
        ASF subversion and git services added a comment -

        Commit 1558688 from Mark Miller in branch 'dev/trunk'
        [ https://svn.apache.org/r1558688 ]

        SOLR-5636: SolrRequestParsers does some xpath lookups on every request, which can cause concurrency issues.

        Show
        ASF subversion and git services added a comment - Commit 1558688 from Mark Miller in branch 'dev/trunk' [ https://svn.apache.org/r1558688 ] SOLR-5636 : SolrRequestParsers does some xpath lookups on every request, which can cause concurrency issues.
        Hide
        ASF subversion and git services added a comment -

        Commit 1558690 from Mark Miller in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1558690 ]

        SOLR-5636: SolrRequestParsers does some xpath lookups on every request, which can cause concurrency issues.

        Show
        ASF subversion and git services added a comment - Commit 1558690 from Mark Miller in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1558690 ] SOLR-5636 : SolrRequestParsers does some xpath lookups on every request, which can cause concurrency issues.
        Hide
        Erik Hatcher added a comment -

        any numbers/ideas on how much faster this makes Solr requests?

        Show
        Erik Hatcher added a comment - any numbers/ideas on how much faster this makes Solr requests?
        Hide
        Mark Miller added a comment -

        The DOM is all in memory, so I would guess it was not a huge hit, but I have not measured.

        Show
        Mark Miller added a comment - The DOM is all in memory, so I would guess it was not a huge hit, but I have not measured.
        Hide
        Mark Miller added a comment -

        This might as well go into a 4.6.1 respin.

        Show
        Mark Miller added a comment - This might as well go into a 4.6.1 respin.
        Hide
        ASF subversion and git services added a comment -

        Commit 1559582 from Mark Miller in branch 'dev/branches/lucene_solr_4_6'
        [ https://svn.apache.org/r1559582 ]

        SOLR-5636: SolrRequestParsers does some xpath lookups on every request, which can cause concurrency issues.

        Show
        ASF subversion and git services added a comment - Commit 1559582 from Mark Miller in branch 'dev/branches/lucene_solr_4_6' [ https://svn.apache.org/r1559582 ] SOLR-5636 : SolrRequestParsers does some xpath lookups on every request, which can cause concurrency issues.
        Hide
        ASF subversion and git services added a comment -

        Commit 1559583 from Mark Miller in branch 'dev/trunk'
        [ https://svn.apache.org/r1559583 ]

        SOLR-5636: Move CHANGES entry to 4.6 branch

        Show
        ASF subversion and git services added a comment - Commit 1559583 from Mark Miller in branch 'dev/trunk' [ https://svn.apache.org/r1559583 ] SOLR-5636 : Move CHANGES entry to 4.6 branch
        Hide
        ASF subversion and git services added a comment -

        Commit 1559584 from Mark Miller in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1559584 ]

        SOLR-5636: Move CHANGES entry to 4.6 branch

        Show
        ASF subversion and git services added a comment - Commit 1559584 from Mark Miller in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1559584 ] SOLR-5636 : Move CHANGES entry to 4.6 branch

          People

          • Assignee:
            Mark Miller
            Reporter:
            Mark Miller
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development