Solr
  1. Solr
  2. SOLR-5632

Improve response message for reloading a non-existent core

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 4.6
    • Fix Version/s: 4.7, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      Right now when attempting to reload a non existent core, the CoreAdmin response just contains a stack trace and a message saying "Error handling 'reload' action" with no further information.
      It'd be good to change it to continue printing stack trace in the log but returning a readable message with more information.

      Ideally, we should be fixing this for other CoreAdmin calls too.

      1. SOLR-5632.patch
        2 kB
        Anshum Gupta

        Activity

        Hide
        Anshum Gupta added a comment -

        Here's a patch with a test.

        Show
        Anshum Gupta added a comment - Here's a patch with a test.
        Hide
        ASF subversion and git services added a comment -

        Commit 1558459 from Mark Miller in branch 'dev/trunk'
        [ https://svn.apache.org/r1558459 ]

        SOLR-5632: Improve response message for reloading a non-existent core.

        Show
        ASF subversion and git services added a comment - Commit 1558459 from Mark Miller in branch 'dev/trunk' [ https://svn.apache.org/r1558459 ] SOLR-5632 : Improve response message for reloading a non-existent core.
        Hide
        ASF subversion and git services added a comment -

        Commit 1558460 from Mark Miller in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1558460 ]

        SOLR-5632: Improve response message for reloading a non-existent core.

        Show
        ASF subversion and git services added a comment - Commit 1558460 from Mark Miller in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1558460 ] SOLR-5632 : Improve response message for reloading a non-existent core.
        Hide
        ASF subversion and git services added a comment -

        Commit 1558467 from Mark Miller in branch 'dev/trunk'
        [ https://svn.apache.org/r1558467 ]

        SOLR-5632: Fix SolrCore leak.

        Show
        ASF subversion and git services added a comment - Commit 1558467 from Mark Miller in branch 'dev/trunk' [ https://svn.apache.org/r1558467 ] SOLR-5632 : Fix SolrCore leak.
        Hide
        ASF subversion and git services added a comment -

        Commit 1558469 from Mark Miller in branch 'dev/branches/branch_4x'
        [ https://svn.apache.org/r1558469 ]

        SOLR-5632: Fix SolrCore leak.

        Show
        ASF subversion and git services added a comment - Commit 1558469 from Mark Miller in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1558469 ] SOLR-5632 : Fix SolrCore leak.
        Hide
        Mark Miller added a comment -

        Thanks Anshum!

        Show
        Mark Miller added a comment - Thanks Anshum!

          People

          • Assignee:
            Mark Miller
            Reporter:
            Anshum Gupta
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development